Skip to content

Add appconfiguration to Spring Cloud Azure#34824

Merged
Netyyyy merged 1 commit into
Azure:feature/spring-boot-3from
Netyyyy:myao/add_appconfiguration_to_sca
May 9, 2023
Merged

Add appconfiguration to Spring Cloud Azure#34824
Netyyyy merged 1 commit into
Azure:feature/spring-boot-3from
Netyyyy:myao/add_appconfiguration_to_sca

Conversation

@Netyyyy

@Netyyyy Netyyyy commented May 6, 2023

Copy link
Copy Markdown
Contributor

Description

Add all spring cloud azure app configuration related artifacts to spring-cloud-azure-dependencies.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label May 6, 2023
@Netyyyy Netyyyy marked this pull request as ready for review May 6, 2023 07:05
Comment on lines +131 to +155
<dependency>
<groupId>com.azure.spring</groupId>
<artifactId>spring-cloud-azure-starter-appconfiguration-config</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.azure.spring</groupId>
<artifactId>spring-cloud-azure-appconfiguration-config</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.azure.spring</groupId>
<artifactId>spring-cloud-azure-appconfiguration-config-web</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.azure.spring</groupId>
<artifactId>spring-cloud-azure-feature-management</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>com.azure.spring</groupId>
<artifactId>spring-cloud-azure-feature-management-web</artifactId>
<version>${project.version}</version>
</dependency>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check wether this has been in the main branch.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, already exist

<artifactId>spring-cloud-azure-starter-appconfiguration-config</artifactId>

@saragluna

Copy link
Copy Markdown
Member

@mrm9084 fyi, we are adding these libraries in this PR because they were not included in the BOM for release 5.1.0 by mistake.

@Netyyyy Netyyyy merged commit 048f253 into Azure:feature/spring-boot-3 May 9, 2023
@Netyyyy Netyyyy deleted the myao/add_appconfiguration_to_sca branch May 25, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants