Feature management all support#34908
Merged
Merged
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
saragluna
requested changes
May 12, 2023
| try { | ||
| JsonNode node = CASE_INSENSITIVE_MAPPER.readTree(item.getValue()); | ||
| JsonNode conditions = node.get("conditions"); | ||
| if (conditions != null && conditions.get("requirement_type") != null) { |
Member
There was a problem hiding this comment.
nit: Should we consider define this property name requirement_type as a constant as well?
Member
There was a problem hiding this comment.
Why it's underscore in requirement_type, but in the pojo it's requirement-type?
Member
Author
There was a problem hiding this comment.
requirement_type comes from app configuration but requirement-type would be how Spring expects it when mapping configurations.
mrm9084
marked this pull request as ready for review
May 16, 2023 23:11
mrm9084
requested review from
Netyyyy,
backwind1233,
chenrujun,
fangjian0423,
hui1110,
moarychan,
stliu and
yiliuTo
as code owners
May 16, 2023 23:11
saragluna
approved these changes
May 18, 2023
saragluna
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines