Cherry pick 34898 to sb3 branch#34955
Merged
saragluna merged 3 commits intoMay 16, 2023
Merged
Conversation
Azure#34898) * Moved azure-spring-data-cosmos-test to azure-spring-data-cosmos module * Deleted azure-spring-data-cosmos-test module * Fixed build issues with spring-data-cosmos-test module * Opened azure.cosmos.implementation package to com.azure.spring.data.cosmos for testing * Updated AdditionalModules with azure-spring-data-cosmos module * Relying on current version of azure-cosmos * Reverting the current version change * Disabled tests with implementation packages accessor * Suppressing test checks * Added suppressions for spring data cosmos test files * updated pom.xml with experiments * testing junit * Fixed unit tests * Fixed application properties account host and key * Removed protocol and other unnecessary command line args * Passing env variables * Adding additional args back * Fixing java 17 tests * Fixed some tests with refelction issues * Fixed more tests * Fixed more tests * Fixed more tests
Netyyyy
reviewed
May 16, 2023
| /sdk/spring/spring-cloud-azure-starter-appconfiguration-config/ @mrm9084 @backwind1233 @chenrujun @hui1110 @netyyyy @saragluna @stliu @yiliuTo @moarychan @fangjian0423 | ||
|
|
||
| # PRLabel: %azure-spring | ||
| /sdk/spring/azure-spring-data-cosmos/ @kushagraThapar @FabianMeiswinkel @backwind1233 @chenrujun @hui1110 @netyyyy @saragluna @stliu @yiliuTo @xinlian12 @moarychan @aayush3011 @simorenoh @fangjian0423 @jeet1995 @Pilchie No newline at end of file |
saragluna
commented
May 16, 2023
Comment on lines
+184
to
+195
| <dependency> | ||
| <groupId>org.junit.vintage</groupId> | ||
| <artifactId>junit-vintage-engine</artifactId> | ||
| <version>5.9.1</version> <!-- {x-version-update;org.junit.vintage:junit-vintage-engine;external_dependency} --> | ||
| <scope>test</scope> | ||
| <exclusions> | ||
| <exclusion> | ||
| <groupId>org.hamcrest</groupId> | ||
| <artifactId>hamcrest-core</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
Member
Author
There was a problem hiding this comment.
better use jupiter here instead of vintage engine.
saragluna
requested review from
backwind1233,
chenrujun,
fangjian0423,
hui1110,
moarychan,
stliu and
yiliuTo
as code owners
Netyyyy
reviewed
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title, to cherry pick #34898 to spring boot 3 branch.