Skip to content

Add back spring-data-cosmos to sb3#35290

Merged
Netyyyy merged 11 commits into
Azure:feature/spring-boot-3from
Netyyyy:myao/support_sdc_starter
Jun 7, 2023
Merged

Add back spring-data-cosmos to sb3#35290
Netyyyy merged 11 commits into
Azure:feature/spring-boot-3from
Netyyyy:myao/support_sdc_starter

Conversation

@Netyyyy

@Netyyyy Netyyyy commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

# Description

Add back spring-data-cosmos to sb3

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jun 5, 2023
@azure-sdk

azure-sdk commented Jun 5, 2023

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure
azure-spring-data-cosmos

@kushagraThapar kushagraThapar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread eng/versioning/version_client.txt Outdated
com.azure:azure-sdk-template-two;1.0.0-beta.1;1.0.0-beta.1
com.azure:azure-sdk-template-three;1.0.0-beta.1;1.0.0-beta.1
com.azure:azure-spring-data-cosmos;3.34.0;3.35.0-beta.1
com.azure:azure-spring-data-cosmos;5.3.0-beta.1;5.3.0-beta.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about moving this to be with all other Spring Cloud Azure libs?

@Netyyyy
Netyyyy merged commit 0f89a43 into Azure:feature/spring-boot-3 Jun 7, 2023
@Netyyyy
Netyyyy deleted the myao/support_sdc_starter branch June 26, 2023 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants