Skip to content

Make appconfig IT to be independent#35320

Merged
saragluna merged 2 commits into
Azure:mainfrom
Netyyyy:myao/update_appconfig_IT
Jun 7, 2023
Merged

Make appconfig IT to be independent#35320
saragluna merged 2 commits into
Azure:mainfrom
Netyyyy:myao/update_appconfig_IT

Conversation

@Netyyyy

@Netyyyy Netyyyy commented Jun 6, 2023

Copy link
Copy Markdown
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

Adjust the position of appconfiguration-config IT to make it an independent part

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jun 6, 2023
@Netyyyy

Netyyyy commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

/azp run java - spring -tests

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@Netyyyy Netyyyy marked this pull request as ready for review June 6, 2023 09:28
@Netyyyy

Netyyyy commented Jun 6, 2023

Copy link
Copy Markdown
Contributor Author

@mrm9084 please help take a look, if it is ok, I will sync to springboot3 as well, thanks.

Comment thread sdk/spring/tests.yml Outdated

@saragluna saragluna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need to wait for Matt to sign off.

@mrm9084 mrm9084 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we will also make the change in the spring-boot-3 branch

@saragluna saragluna merged commit 1aed902 into Azure:main Jun 7, 2023
Netyyyy added a commit to Netyyyy/azure-sdk-for-java that referenced this pull request Jun 7, 2023
* move appconfig IT
* Update tests.yml
Netyyyy added a commit that referenced this pull request Jun 14, 2023
* Make appconfig IT to be independent (#35320)

* move appconfig IT
* Update tests.yml

* move appconfig IT
@Netyyyy Netyyyy deleted the myao/update_appconfig_IT branch June 30, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants