findById Optimization (#35261)#35403
Merged
Merged
Conversation
* findById Optimization * reformat * add hashcode override and licence to BasicItem * improve point read test * address linting errors * fix linting errors * fix linting * some enhancements * fix build errors * fix testFindByIdNull integration test failure * add return null for CosmosAccessException * address Fabian review comment * update change log * address review comments * fix build errors * fix build errors * fix build errors * fix build errors * add testFindByIdWithInvalidId * add missing license header * add repository api checks for point read/query * change pointReadWarningLogged to primitive * edit change log and warning text * add extra checks per Kushagra's comments * Update CHANGELOG.md --------- Co-authored-by: Theo van Kraay <thvankra@microsoft.com> Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
trande4884
requested review from
FabianMeiswinkel,
Netyyyy,
Pilchie,
aayush3011,
backwind1233,
chenrujun,
fangjian0423,
hui1110,
jeet1995,
kushagraThapar,
moarychan,
saragluna,
simorenoh,
stliu,
xinlian12 and
yiliuTo
as code owners
June 9, 2023 16:34
Member
Author
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
kushagraThapar
approved these changes
Jun 9, 2023
kushagraThapar
left a comment
kushagraThapar
left a comment
Member
There was a problem hiding this comment.
LGTM, with minor changes
Co-authored-by: Kushagra Thapar <kuthapar@microsoft.com>
Member
Author
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findById Optimization
reformat
add hashcode override and licence to BasicItem
improve point read test
address linting errors
fix linting errors
fix linting
some enhancements
fix build errors
fix testFindByIdNull integration test failure
add return null for CosmosAccessException
address Fabian review comment
update change log
address review comments
fix build errors
fix build errors
fix build errors
fix build errors
add testFindByIdWithInvalidId
add missing license header
add repository api checks for point read/query
change pointReadWarningLogged to primitive
edit change log and warning text
add extra checks per Kushagra's comments
Update CHANGELOG.md
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines