Client Level Diagnostics for Spring SDK by trande4884 · Pull Request #35546 · Azure/azure-sdk-for-java

trande4884 · 2023-06-20T20:27:52Z

Description

Adding threshold support for diagnostics at the client level.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

The pull request does not introduce [breaking changes]
CHANGELOG is updated for new features, bug fixes or other significant changes.
I have read the contribution guidelines.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

Merging

This reverts commit ade7932.

This reverts commit 6bab94e.

azure-sdk · 2023-06-20T20:38:28Z

API change check

API changes are not detected in this pull request.

…ande4884/azure-sdk-for-java-trande into trande_clientLevelDiagnostics

trande4884 · 2023-06-21T13:33:26Z

No test cases to commit for this change, but I have confirmed with local testing that the configured values are being used.

FabianMeiswinkel

Please see comments about public surface area (configs)

FabianMeiswinkel

LGTM now

FabianMeiswinkel · 2023-06-27T13:57:39Z

Would be nice to have a brief sample on how to enable logging with reaosnable defaults in readme.md - ultimately we want to enable everyone these logs, correct? Also makes it easier for support to point customers to a sample on how to enable them

kushagraThapar

@trande4884 looks great, can we add more samples for this in the readme section?
Also, we have not added any tests yet. Can we add some tests to make sure this works end to end?

trande4884 · 2023-07-06T21:03:10Z

@trande4884 looks great, can we add more samples for this in the readme section? Also, we have not added any tests yet. Can we add some tests to make sure this works end to end?

I can add samples, but for these attributes added on the configuration there is no real way to test them usually, I did manually test to make sure the values were being passed along. Is there some specific aspect I should be trying to test?

kushagraThapar · 2023-07-06T21:27:17Z

@trande4884 looks great, can we add more samples for this in the readme section? Also, we have not added any tests yet. Can we add some tests to make sure this works end to end?

I can add samples, but for these attributes added on the configuration there is no real way to test them usually, I did manually test to make sure the values were being passed along. Is there some specific aspect I should be trying to test?

Is there a way to test using DiagnosticsHandler? - checking if the APIs are getting called when thresholds are met?

trande4884 · 2023-07-07T17:10:51Z

@kushagraThapar @FabianMeiswinkel more information added to readme as well as a test case.

…nto trande_clientLevelDiagnostics

trande4884 · 2023-07-07T19:19:45Z

/azp run java - spring - tests

azure-pipelines · 2023-07-07T19:19:59Z

Azure Pipelines successfully started running 1 pipeline(s).

Changing wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

Wording change. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

trande4884 · 2023-07-07T20:12:15Z

/azp run java - spring - tests

azure-pipelines · 2023-07-07T20:12:30Z

Azure Pipelines successfully started running 1 pipeline(s).

* Merging * Revert "Merging" This reverts commit ade7932. * Exposing diagnostic threshold's at the client level in Spring SDK. * Revert "Revert "Merging"" This reverts commit 6bab94e. * Updating changelog. * Removing unused import. * Adding defaults to application.properties * Fixing copy/paste error in code. * Fixing PR comments. * Fixing PR comments. * Fixing PR comments. * Adding test case. * Adding javaagent sample to readme. * Updating readme wording. * Removing unused imports. * Fixing bad merge resolution. * Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md Changing wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com> * Update sdk/spring/azure-spring-data-cosmos/README.md Wording change. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com> --------- Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

* Client Level Diagnostics for Spring SDK (#35546) * Merging * Revert "Merging" This reverts commit ade7932. * Exposing diagnostic threshold's at the client level in Spring SDK. * Revert "Revert "Merging"" This reverts commit 6bab94e. * Updating changelog. * Removing unused import. * Adding defaults to application.properties * Fixing copy/paste error in code. * Fixing PR comments. * Fixing PR comments. * Fixing PR comments. * Adding test case. * Adding javaagent sample to readme. * Updating readme wording. * Removing unused imports. * Fixing bad merge resolution. * Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md Changing wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com> * Update sdk/spring/azure-spring-data-cosmos/README.md Wording change. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com> --------- Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com> * Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com> * Update README.md Adding readme file changes. Co-Authored-By: Kushagra Thapar <kushuthapar@gmail.com> * Update README.md Adding changes to readme file --------- Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

trande4884 and others added 4 commits June 8, 2023 12:41

Merging

ade7932

Merge pull request #1 from Azure/main

59c3a62

Merging

Revert "Merging"

6bab94e

This reverts commit ade7932.

Exposing diagnostic threshold's at the client level in Spring SDK.

a170c54

Revert "Revert "Merging""

08a37c3

This reverts commit 6bab94e.

trande4884 added 5 commits June 21, 2023 09:11

Updating changelog.

c6fd252

Merge branch 'trande_clientLevelDiagnostics' of https://github.com/tr…

5bda564

…ande4884/azure-sdk-for-java-trande into trande_clientLevelDiagnostics

Removing unused import.

2832639

Adding defaults to application.properties

dca95cd

Fixing copy/paste error in code.

51d70fa

trande4884 marked this pull request as ready for review June 21, 2023 13:33

trande4884 requested a review from backwind1233 as a code owner June 21, 2023 13:33

FabianMeiswinkel reviewed Jun 26, 2023

View reviewed changes

Comment thread ...azure-spring-data-cosmos/src/samples/java/com/azure/spring/data/cosmos/AppConfiguration.java Outdated

FabianMeiswinkel reviewed Jun 26, 2023

View reviewed changes

Comment thread ...azure-spring-data-cosmos/src/samples/java/com/azure/spring/data/cosmos/AppConfiguration.java Outdated

FabianMeiswinkel requested changes Jun 26, 2023

View reviewed changes

trande4884 added 2 commits June 27, 2023 09:41

Fixing PR comments.

eb9c5f4

Fixing PR comments.

2b9b56e

FabianMeiswinkel approved these changes Jun 27, 2023

View reviewed changes

Comment thread ...g-data-cosmos/src/samples/java/com/azure/spring/data/cosmos/AppConfigurationCodeSnippet.java Outdated

kushagraThapar requested changes Jul 6, 2023

View reviewed changes

Comment thread ...mos/src/test/java/com/azure/spring/data/cosmos/repository/SecondaryTestRepositoryConfig.java

trande4884 added 4 commits July 6, 2023 23:30

Fixing PR comments.

3bba404

Adding test case.

8fc8f54

Adding javaagent sample to readme.

8263fa0

Updating readme wording.

07a2eb5

trande4884 and others added 4 commits July 7, 2023 13:13

Merge branch 'main' into trande_clientLevelDiagnostics

f81feff

Removing unused imports.

5b49c3f

Merge remote-tracking branch 'origin/trande_clientLevelDiagnostics' i…

fd4a9d0

…nto trande_clientLevelDiagnostics

Fixing bad merge resolution.

fe37abd

kushagraThapar approved these changes Jul 7, 2023

View reviewed changes

Comment thread sdk/spring/azure-spring-data-cosmos/CHANGELOG.md Outdated

Comment thread sdk/spring/azure-spring-data-cosmos/README.md Outdated

trande4884 and others added 2 commits July 7, 2023 16:11

Update sdk/spring/azure-spring-data-cosmos/CHANGELOG.md

44e5681

Changing wording. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

Update sdk/spring/azure-spring-data-cosmos/README.md

c156dec

Wording change. Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

kushagraThapar approved these changes Jul 7, 2023

View reviewed changes

trande4884 merged commit 705fa70 into Azure:main Jul 8, 2023

Uh oh!

Conversation

trande4884 commented Jun 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

Uh oh!

azure-sdk commented Jun 20, 2023

Uh oh!

trande4884 commented Jun 21, 2023

Uh oh!

Uh oh!

Uh oh!

FabianMeiswinkel left a comment

Choose a reason for hiding this comment

Uh oh!

FabianMeiswinkel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FabianMeiswinkel commented Jun 27, 2023

Uh oh!

kushagraThapar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trande4884 commented Jul 6, 2023

Uh oh!

kushagraThapar commented Jul 6, 2023

Uh oh!

trande4884 commented Jul 7, 2023

Uh oh!

trande4884 commented Jul 7, 2023

Uh oh!

azure-pipelines Bot commented Jul 7, 2023

Uh oh!

Uh oh!

Uh oh!

trande4884 commented Jul 7, 2023

Uh oh!

azure-pipelines Bot commented Jul 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

trande4884 commented Jun 20, 2023 •

edited

Loading