Fix application id too long in AzureSpringIdentifier#35675
Merged
Netyyyy merged 6 commits intoJun 30, 2023
Merged
Conversation
Netyyyy
requested review from
backwind1233,
chenrujun,
fangjian0423,
hui1110,
moarychan,
saragluna,
stliu and
yiliuTo
as code owners
June 29, 2023 08:52
Collaborator
|
API change check API changes are not detected in this pull request. |
saragluna
reviewed
Jun 30, 2023
| // b2c: for AAD B2C | ||
| private static final Logger LOGGER = LoggerFactory.getLogger(AzureSpringIdentifier.class); | ||
| public static final String VERSION = getVersion(); | ||
| public static final int MAX_VERSION_LENGTH = 13; |
saragluna
reviewed
Jun 30, 2023
saragluna
reviewed
Jun 30, 2023
Comment on lines
+9
to
+12
| public class AzureSpringIdentifierTests { | ||
|
|
||
| @Test | ||
| public void testFormatVersion() { |
Member
There was a problem hiding this comment.
nit: no public needed in tests
saragluna
approved these changes
Jun 30, 2023
Netyyyy
added a commit
that referenced
this pull request
Jun 30, 2023
Member
|
@Netyyyy please don't forget to port this change to the sb3 branch. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix application id too long in AzureSpringIdentifier
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines