Updated spring-data-cosmos read me to fix javadoc errors and sb3 version#36065
Merged
kushagraThapar merged 1 commit intoJul 25, 2023
Conversation
kushagraThapar
requested review from
FabianMeiswinkel,
Netyyyy,
Pilchie,
aayush3011,
backwind1233,
chenrujun,
fangjian0423,
hui1110,
jeet1995,
moarychan,
saragluna,
simorenoh,
stliu,
xinlian12 and
yiliuTo
as code owners
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
xinlian12
reviewed
Jul 25, 2023
| Mono<Boolean> existsByLastNameIsNull(); | ||
|
|
||
| @Query(value = "SELECT * FROM a WHERE ARRAY_CONTAINS(@firstNames, a.firstName) ") | ||
| @Query(value = "SELECT * FROM a WHERE ARRAY_CONTAINS(@firstNames, a.firstName) order by a.id ") |
Member
There was a problem hiding this comment.
why changing the query? should we add another test for the order by?
Member
Author
There was a problem hiding this comment.
There is already another one for order by :)
Changing this one so that we can match the results 100% of the time always, currently they come unordered and can come in any order without any guarantee, causing the test to be flaky.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated spring-data-cosmos read me to fix javadoc errors and sb3 version