Skip to content

fix cosmos auditing circular ref#36123

Merged
saragluna merged 4 commits into
Azure:feature/spring-boot-3from
saragluna:xiada/fix-cosmos-auditing-circular-ref
Jul 27, 2023
Merged

fix cosmos auditing circular ref#36123
saragluna merged 4 commits into
Azure:feature/spring-boot-3from
saragluna:xiada/fix-cosmos-auditing-circular-ref

Conversation

@saragluna

Copy link
Copy Markdown
Member

Description

Fix #35736. The regression was brought in #34878. However, this fix is not ideal, because it will create a new instance of CosmosMappingContext and injects it into the auditingHandler.

The circular reference is caused by our CosmosTempate references the auditingHandler directly, which should be propagated via the event to do the auditing.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jul 27, 2023
@azure-sdk

azure-sdk commented Jul 27, 2023

Copy link
Copy Markdown
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-spring-data-cosmos
spring-cloud-azure-autoconfigure

@Netyyyy

Netyyyy commented Jul 27, 2023

Copy link
Copy Markdown
Contributor

/azp run java - spring - tests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy Netyyyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna
saragluna merged commit 8a0986c into Azure:feature/spring-boot-3 Jul 27, 2023
@kushagraThapar

Copy link
Copy Markdown
Member

Thanks for the fix @saragluna - shouldn't we need to fix this on main branch as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants