fix cosmos auditing circular ref#36123
Merged
saragluna merged 4 commits intoJul 27, 2023
Merged
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Contributor
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saragluna
marked this pull request as ready for review
July 27, 2023 05:34
saragluna
requested review from
FabianMeiswinkel,
Netyyyy,
Pilchie,
aayush3011,
backwind1233,
chenrujun,
fangjian0423,
hui1110,
jeet1995,
kushagraThapar,
moarychan,
simorenoh,
stliu,
xinlian12 and
yiliuTo
as code owners
July 27, 2023 05:34
Member
|
Thanks for the fix @saragluna - shouldn't we need to fix this on main branch as well? |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #35736. The regression was brought in #34878. However, this fix is not ideal, because it will create a new instance of
CosmosMappingContextand injects it into the auditingHandler.The circular reference is caused by our
CosmosTempatereferences the auditingHandler directly, which should be propagated via the event to do the auditing.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines