Update STS end point handling logic in service bus configuration. #364
Merged
Conversation
Contributor
There was a problem hiding this comment.
Nit: need to make sure that connectionString.getStsEndpoint() doesn't have / at the end so you don't end up with double //
Contributor
|
Maybe it's good to add a unit test with a customized StsEndpoint to make sure that the code parses and uses the value correctly |
Author
|
I am pro unit test, but this class is a private class, so it is not testable as a unit test. However, our integration test does cover this. |
gcheng
pushed a commit
that referenced
this pull request
Jun 11, 2013
Update STS end point handling logic in service bus configuration.
jianghaolu
pushed a commit
to jianghaolu/azure-sdk-for-java
that referenced
this pull request
Apr 5, 2017
Update STS end point handling logic in service bus configuration.
g2vinay
pushed a commit
to g2vinay/azure-sdk-for-java
that referenced
this pull request
Mar 4, 2019
…view-dev New storage sdk v10 preview dev
sima-zhu
pushed a commit
to sima-zhu/azure-sdk-for-java
that referenced
this pull request
Mar 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the logic to handle STS end points in ServiceBusConnectionSettings.
#358