Fix broken unit tests on CI machine#370
Conversation
…into release Conflicts: microsoft-azure-api/src/test/java/com/microsoft/windowsazure/services/scenarios/MediaServiceWrapper.java
There was a problem hiding this comment.
Nit: should the .format be on same line with String?
There was a problem hiding this comment.
this was auto-formated by Eclipse, I guess when the line is long enough, Eclipse will try to put it into two lines. Even if I change it back, next time we click save, it will be changed into two line format :(
|
LGTM |
There was a problem hiding this comment.
Is media services no longer returning version numbers, or is it that they're churning too quickly to keep the test working?
If they change a lot, it might be worth having an assertNotNull on the getVersion call to make sure you got something, even if we can't control/predict what the actual value will be.
There was a problem hiding this comment.
It is a good idea to make some validation, I will add a little bit logic to ensure the length of the version element is greater than 0.
Fix broken unit tests on CI machine
Fix broken unit tests on CI machine
3 participants
No description provided.