[Automation] Generate SDK based on TypeSpec 0.14.1#39109
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. com.azure:azure-analytics-purview-datamap |
| super(resourceType); | ||
| setResourceType("Fhir_R4_DomainResource"); |
There was a problem hiding this comment.
setResourceType not generated in class.
The class is a bit unusual. It has a base class of FhirR4Resource, but only this class have discriminator property.
There was a problem hiding this comment.
Thanks for finding this. Looks like there is an edge case with code generation where the discriminator is a required property.
| reader.skipChildren(); | ||
| } | ||
| } | ||
| MessageTemplateItem deserializedMessageTemplateItem = new MessageTemplateItem(language, status); |
There was a problem hiding this comment.
The class was customized to abstract by service.
What can we do via customization to skip this fromJsonKnownDiscriminator?
There was a problem hiding this comment.
The method can be deleted with customizations, but I think a better option would be allowing the type to be instantiated as Jackson had to be handling this before (likely by creating anonymous implementations)
| super(language, status); | ||
| setKind(CommunicationMessagesChannel.WHATS_APP); |
There was a problem hiding this comment.
setKind not accessible in a different pacakge
There was a problem hiding this comment.
This is a problem not relate to stream-style-serialization.
Model by Jackson would have the setKind method as well (as the impl changed), and it would have the same problem. Azure/autorest.java#2574
As this case, our 0.14.x without bug fix would block service.
3 participants
[Automation] Generate SDK based on TypeSpec 0.14.1
azure-communication-jobrouter
serializeAsJsonMergePatchin different packageazure-communication-messages
setKindnot accessible in different package, commentedcontentsafety
easm
healthinsights
I've already skipped
azure-ai-openai. Its customization targets Jackson.Fix on
azure-communication-jobrouterprobably takes time.The issue on
azure-communication-messagesandhealthinsightsmay not be easy.Should we temporarily skip these libs and check in 0.14.1, then fix them later (may choose either set the flag to false in tspconfig; or temporary skip the codegen CI).
List of issues put to #38569 (comment)