Generate SDK based on TypeSpec 0.15.6 (with stream-style-serialization=false to some lib)#39287
Conversation
weidongxu-microsoft
changed the title
|
One major issue is from text-translation (if this is the only remaining block, I would change it to stream-style-serialization=false) |
weidongxu-microsoft
changed the title
| * default scoring formula that uses the number of job labels that the worker labels match, as well as the number | ||
| * of label selectors the worker labels match and/or exceed using a logistic function | ||
| * (https://en.wikipedia.org/wiki/Logistic_function). | ||
| * Define a scoring rule to use, when calculating a score to determine the best worker. If not set, will use a default scoring formula that uses the number of job labels that the worker labels match, as well as the number of label selectors the worker labels match and/or exceed using a logistic function (https://en.wikipedia.org/wiki/Logistic_function). |
There was a problem hiding this comment.
Seems Javadoc formatting broke?
There was a problem hiding this comment.
Does checkstyle no longer check char per line on Javadoc/comment?
I thought previously checkstyle would fail if line over 120 (exclude a few exceptions that line break not possible).
There was a problem hiding this comment.
It should, but I'll need to check if there is a suppression that is including too much to be skipped.
There was a problem hiding this comment.
I think the line wrap on Javadoc comment works on the new release 0.15.6.
Here is just comment, and line wrap not taking effect.
| import com.azure.core.credential.KeyCredential; | ||
| import com.azure.core.credential.TokenCredential; | ||
| import java.net.MalformedURLException; | ||
| import java.net.URL; |
There was a problem hiding this comment.
Hmmm, something seems off with formatting. I'll take a look into why this is happening
There was a problem hiding this comment.
Is it the order of the "import"?
I guess part of it is via partial-update, when java-parser merge the imports from existing file and imports from generate file.
The part on formatting seems that it no longer order the imports.
weidongxu-microsoft
changed the title
| { | ||
| "ignore": true, | ||
| "code": "java.annotation.removed", | ||
| "package": "com.azure.ai.contentsafety.models", | ||
| "annotationType": "com.fasterxml.jackson.annotation.JsonProperty", | ||
| "justification": "Migrate to azure-json." | ||
| }, | ||
| { | ||
| "ignore": true, | ||
| "code": "java.annotation.removed", | ||
| "package": "com.azure.ai.contentsafety.models", | ||
| "annotationType": "com.fasterxml.jackson.annotation.JsonCreator", | ||
| "justification": "Migrate to azure-json." | ||
| } |
There was a problem hiding this comment.
Suppress revapi on removal of Jackson annotations, currently only for contentsafety -- the GA lib.
weidongxu-microsoft
changed the title
4 participants
fix Azure/autorest.java#2662
spec PR Azure/azure-rest-api-specs#28305 -- disabled stream-style-serialization for 6 libs
include migrate to stream-style-serialization for 4 libs:
skip openai
skip easm
Will create separate task for them (either update to latest typespec, or try migrate to stream-style-serialization which need a new test recording)
Link #38569
apiview for contentsafety
#39287 (comment)
diff
API added
TextBlocklist createOrUpdateTextBlocklist(String name, TextBlocklist options).It is JSON Merge Patch API that is supported under stream-style-serialization.
@zhaiyutong Please take a review. I may need your help to run the live test (or help me with the env that runs it) and a follow-up release.
apiview for communication-messages
https://apiview.dev/Assemblies/Review/6562e5ee918f497cba32cbf009b4de95/e81ad5b30e934034b274badd1404e691?diffRevisionId=beebd3ccefc94828975b409514c235c6&doc=False&diffOnly=True
This module is not migrated to stream-style-serialization.
These added "Kind" classes corresponds to the discriminator properties.
@arifibrahim4 Please take a review.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines