Skip to content

[JAVA] [ACS Identity] Fix test failure due to dependency conflict#39786

Merged
mjafferi-msft merged 1 commit into
Azure:mainfrom
mjafferi-msft:resolve_dependency_conflict
Apr 23, 2024
Merged

[JAVA] [ACS Identity] Fix test failure due to dependency conflict#39786
mjafferi-msft merged 1 commit into
Azure:mainfrom
mjafferi-msft:resolve_dependency_conflict

Conversation

@mjafferi-msft

@mjafferi-msft mjafferi-msft commented Apr 18, 2024

Copy link
Copy Markdown
Member

Description

Tests are failing in pipeline because of dependency diamonds that arise when azure-core-http-netty ships with new Netty dependency versions while Communication Common hasn't shipped yet.
We need to include a direct dependency on azure-core-http-netty to prevent such failure.

StacklessClosedChannelException when running tests

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@mjafferi-msft mjafferi-msft marked this pull request as ready for review April 23, 2024 08:28
@mjafferi-msft mjafferi-msft merged commit 69ed7a7 into Azure:main Apr 23, 2024
@mjafferi-msft mjafferi-msft deleted the resolve_dependency_conflict branch April 23, 2024 08:43
mssfang added a commit that referenced this pull request Apr 23, 2024
@mssfang @azure-sdk
@weidongxu-microsoft @drielenr @FabianMeiswinkel @xinlian12 @kushagraThapar @mjafferi-msft @XiaofeiCao @ChristopherManthei @jeet1995
[PatchRelease][Part1] Prepare April Patch Releases (#39877)
1030229 
* [Automation] Generate Fluent Lite from help#package-2024-03-01-preview (#39848)

* Increment package versions for devcenter releases (#39851)

* Increment package versions for selfhelp releases (#39854)

* Increment package versions for standbypool releases (#39856)

* [Automation] Generate Fluent Lite from confidentialledger#package-preview-2023-06 (#39855)

* [Automation] Generate Fluent Lite from confidentialledger#package-preview-2023-06

* ignore api-version in playback

---------

Co-authored-by: Weidong Xu <weidxu@microsoft.com>

* Regen devcenter from latest main (#39836)

* Increment package versions for confidentialledger releases (#39859)

* [Automation] Generate Fluent Lite from support#package-2024-04 (#39860)

* [Automation] External Change

* [Automation] Generate Fluent Lite from support#package-2024-04

* Update CHANGELOG.md

---------

Co-authored-by: Weidong Xu <weidxu@microsoft.com>

* Increment package versions for support releases (#39864)

* Added capability to use (and enforce) native netty transport in azure-cosmos-spark (#39834)

* Add capability to use (and enforce) native netty transport in azure-cosmos-spark

* Update pom.xml

* Fix build breaks

* Update sdk/cosmos/azure-cosmos-spark_3_2-12/docs/configuration-reference.md

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>

* Fixing build  breaks regarding antrun plugin

* Update pom.xml

* Update sdk/cosmos/azure-cosmos-spark_3_2-12/docs/configuration-reference.md

Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

* Changelogs

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>

* Adding azure-core-http-netty dependency to resolve conflicts (#39786)

* [Automation] Generate Fluent Lite from hybridcompute#package-preview-2023-10 (#39852)

* mgmt deviceregistry, local generate from tsp (#39831)

* generate

* manual changelog.md

changelog release date

* fix failed generation sideeffect

* update tsp-location.yaml

* Fix for Remote Rendering build failure (#39868)

* This fixes an issue with Netty version resolution.

Co-authored-by: Christopher Manthei <chmant@microsoft.com>

* Added API to inject custom serializer for point read and query (#38997)

* Added API to inject custom serializer for point read and query

* Update CosmosItemSerializer.java

* Adding CreateItemCustomSerializer

* Update DatabaseAccount.java

* Update JsonSerializable.java

* Fixing primitive serialization

* Update PrimitiveJsonNodeMap.java

* Update ItemBulkOperation.java

* Iterating on fix

* Fixing build issues

* Update CosmosItemSerializer.java

* Fixing test failures

* Attempting to fix flakiness of Change feed split tests

* Update Utils.java

* Iterating on test coverage

* Iterating on test coverage

* Update Utils.java

* Update EncryptionUtils.java

* Iterating on test coverage

* Update Utils.java

* Added upsert to test coverage

* Update ImplementationBridgeHelpers.java

* Update Utils.java

* Added Bulk test coverage

* Update ItemBulkOperation.java

* Update CosmosItemSerializer.java

* Adding batch and change feed test coverage

* Update ItemBatchOperation.java

* Update SimpleSerializationTest.java

* Update ParallelDocumentQueryTest.java

* Adding remaining test coverage

* Update CosmosEncryptionItemSerializerTest.java

* Added change log

* Update TestSuiteBase.java

* Update TestSuiteBase.java

* Fixing JavaDoc break

* NITs

* Update CosmosEncryptionAsyncClient.java

* Fixing test failures

* Exclduing netty-all in Spark 3.1 and 3.2

* Reacting to code review feeedback

* Update sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosException.java

Co-authored-by: Abhijeet Mohanty <mabhijeet1995@gmail.com>

* Update sdk/cosmos/azure-cosmos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>

* Update sdk/cosmos/azure-cosmos-encryption/src/main/java/com/azure/cosmos/encryption/CosmosEncryptionAsyncContainer.java

Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>

* Reacting to code review feedback

* Update FeedResponse.java

---------

Co-authored-by: Abhijeet Mohanty <mabhijeet1995@gmail.com>
Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>

* Increment package versions for deviceregistry releases (#39869)

* Updated list of libraries to patch in patch-release.yml

* Reset sources for azure-messaging-webpubsub to the release version 1.2.13.

* Prepare azure-messaging-webpubsub for 1.2.14 patch release.

* Reset sources for azure-storage-blob-cryptography to the release version 12.24.3.

* Prepare azure-storage-blob-cryptography for 12.24.4 patch release.

* Reset sources for azure-data-schemaregistry to the release version 1.4.4.

* Prepare azure-data-schemaregistry for 1.4.5 patch release.

* Reset sources for azure-storage-blob to the release version 12.25.3.

* Prepare azure-storage-blob for 12.25.4 patch release.

* Reset sources for azure-messaging-eventhubs-checkpointstore-blob to the release version 1.19.2.

* Prepare azure-messaging-eventhubs-checkpointstore-blob for 1.19.3 patch release.

* Reset sources for azure-mixedreality-authentication to the release version 1.2.22.

* Prepare azure-mixedreality-authentication for 1.2.23 patch release.

* Reset sources for azure-developer-loadtesting to the release version 1.0.11.

* Prepare azure-developer-loadtesting for 1.0.12 patch release.

* Reset sources for azure-identity-extensions to the release version 1.1.14.

* Prepare azure-identity-extensions for 1.1.15 patch release.

* Reset sources for azure-containers-containerregistry to the release version 1.2.6.

* Prepare azure-containers-containerregistry for 1.2.7 patch release.

* Reset sources for azure-ai-textanalytics to the release version 5.4.4.

* Prepare azure-ai-textanalytics for 5.4.5 patch release.

* Reset sources for azure-storage-queue to the release version 12.20.3.

* Prepare azure-storage-queue for 12.20.4 patch release.

* Reset sources for azure-security-confidentialledger to the release version 1.0.18.

* Prepare azure-security-confidentialledger for 1.0.19 patch release.

* Reset sources for azure-search-documents to the release version 11.6.3.

* Prepare azure-search-documents for 11.6.4 patch release.

* Reset sources for azure-monitor-query to the release version 1.3.0.

* Prepare azure-monitor-query for 1.3.1 patch release.

* Reset sources for azure-ai-metricsadvisor to the release version 1.1.23.

* Prepare azure-ai-metricsadvisor for 1.1.24 patch release.

* Reset sources for azure-security-keyvault-administration to the release version 4.5.1.

* Prepare azure-security-keyvault-administration for 4.5.2 patch release.

* Reset sources for azure-storage-file-share to the release version 12.21.3.

* Prepare azure-storage-file-share for 12.21.4 patch release.

* Reset sources for azure-storage-common to the release version 12.24.3.

* Prepare azure-storage-common for 12.24.4 patch release.

* Reset sources for azure-storage-blob-batch to the release version 12.21.3.

* Prepare azure-storage-blob-batch for 12.21.4 patch release.

* Reset sources for azure-data-schemaregistry-apacheavro to the release version 1.1.15.

* Prepare azure-data-schemaregistry-apacheavro for 1.1.16 patch release.

* Reset sources for azure-security-attestation to the release version 1.1.22.

* Prepare azure-security-attestation for 1.1.23 patch release.

* Reset sources for azure-storage-internal-avro to the release version 12.10.3.

* Prepare azure-storage-internal-avro for 12.10.4 patch release.

* Reset sources for azure-messaging-webpubsub-client to the release version 1.0.1.

* Prepare azure-messaging-webpubsub-client for 1.0.2 patch release.

* Reset sources for azure-security-keyvault-certificates to the release version 4.6.1.

* Prepare azure-security-keyvault-certificates for 4.6.2 patch release.

* Reset sources for azure-ai-formrecognizer to the release version 4.1.6.

* Prepare azure-ai-formrecognizer for 4.1.7 patch release.

* Reset sources for azure-messaging-eventgrid to the release version 4.22.0.

* Prepare azure-messaging-eventgrid for 4.22.1 patch release.

* Reset sources for azure-storage-file-datalake to the release version 12.18.3.

* Prepare azure-storage-file-datalake for 12.18.4 patch release.

* Reset sources for azure-security-keyvault-secrets to the release version 4.8.1.

* Prepare azure-security-keyvault-secrets for 4.8.2 patch release.

* Reset sources for azure-mixedreality-remoterendering to the release version 1.1.27.

* Prepare azure-mixedreality-remoterendering for 1.1.28 patch release.

* Reset sources for azure-iot-deviceupdate to the release version 1.0.16.

* Prepare azure-iot-deviceupdate for 1.0.17 patch release.

* Reset sources for azure-messaging-eventhubs to the release version 5.18.2.

* Prepare azure-messaging-eventhubs for 5.18.3 patch release.

* Reset sources for azure-digitaltwins-core to the release version 1.3.18.

* Prepare azure-digitaltwins-core for 1.3.19 patch release.

* Updated dependencies in libraries and READMEs via version_client.txt

* fixes cspell error:

##[error]./sdk/search/azure-search-documents/CHANGELOG.md:88:123 - Unknown word (Vetor)
##[error]./sdk/search/azure-search-documents/CHANGELOG.md:879:70 - Unknown word (Cleint)

* nio and changefeed are two beta packages and not in the release for patches. Remove their tests will not impact patch release of storage.

* fixed a broken link

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
Co-authored-by: Driele Neves Ribeiro <drielene@microsoft.com>
Co-authored-by: Fabian Meiswinkel <fabianm@microsoft.com>
Co-authored-by: Annie Liang <64233642+xinlian12@users.noreply.github.com>
Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
Co-authored-by: Maqsood Jafferi <mjafferi@microsoft.com>
Co-authored-by: Xiaofei Cao <92354331+XiaofeiCao@users.noreply.github.com>
Co-authored-by: Christopher Manthei <22638947+ChristopherManthei@users.noreply.github.com>
Co-authored-by: Christopher Manthei <chmant@microsoft.com>
Co-authored-by: Abhijeet Mohanty <mabhijeet1995@gmail.com>
Co-authored-by: azure-sdk <azuresdk@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AikoBB AikoBB AikoBB approved these changes
@maximrytych-ms maximrytych-ms Awaiting requested review from maximrytych-ms maximrytych-ms is a code owner

Assignees

No one assigned

Labels

Communication - Identity Communication

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mjafferi-msft @AikoBB