[OpenAI] Migrate azure-json serialization to replace jackson-databind - #39825
Conversation
…her tests passed and recorded
…ray of enumerated string values (word and/or segment) that controls which, if any, timestamp information is emitted to transcription results. - `AudioTranscriptionTimestampGranularity` enum to represent the timestamp granularity options for Whisper transcription. - `AudioTranscriptionWord` class to represent the word timestamp information in the transcription results.
mssfang
added
Client
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
There was a problem hiding this comment.
I had a quick look and seems good! I am just wondering what happened to the usages of FunctionCallPreset , seems like we no longer need it.
Did you try running the tests in LIVE mode? With all the model spread that could be cumbersome, but I guess will absolutely have to do it when we re-record the tests.
There was a problem hiding this comment.
Not entirely sure, but it seems that we don't use the class in this file at all. Maybe we should remove it?
There was a problem hiding this comment.
Good catch! Yes. It is an internal-use model and a duplication to FunctionCallConfig (the difference is extensible enum v.s. enum). Will remove it
There was a problem hiding this comment.
After trying to remove it, found that it is from typespec config:
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/cognitiveservices/OpenAI.Inference/tspconfig.yaml#L31-L32
and
need to see if we can keep one of them
Just reran the tests in LIVE/RECORD mode. Found the toolcall and fucntioncall tests failed only. Will address them before merge |
3 participants
Remove jackson-databind dependency and use
azure-jsoninstead.closes: #39464