Skip to content

Use ClientLogger in testing output#40010

Merged
alzimmermsft merged 7 commits into
Azure:mainfrom
alzimmermsft:AzAll_FixTestLogging
May 6, 2024
Merged

Use ClientLogger in testing output#40010
alzimmermsft merged 7 commits into
Azure:mainfrom
alzimmermsft:AzAll_FixTestLogging

Conversation

@alzimmermsft

Copy link
Copy Markdown
Member

Description

Exploratory PR where many System.out, System.err, and Throwable.printStackTrace calls are replaced with logging using ClientLogger. This should reduce noise seen in CI pipelines and push that information into log files which are more durable and more easily parsed when troubleshooting.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk

azure-sdk commented May 2, 2024

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@weidongxu-microsoft weidongxu-microsoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few formatting error in Analyze CI, otherwise LGTM on ARM libs.

Is there any easy practice when running local (where we may prefer seeing the log on stdout etc.)?

@alzimmermsft

Copy link
Copy Markdown
Member Author

A few formatting error in Analyze CI, otherwise LGTM on ARM libs.

Is there any easy practice when running local (where we may prefer seeing the log on stdout etc.)?

Right now, all libraries when running tests will log to target/test.log at a verbose level for troubleshooting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants