[OpenAI] Fixed ChatRequestUserMessage serialization and deserialization bug - #40687
Merged
Conversation
mssfang
added
the
Client
…nt property in the ChatRequestUserMessage.
Collaborator
|
API change check API changes are not detected in this pull request. |
2 tasks
|
@mssfang any news about this? |
…to OpenAI-ChatRequestUserMessage-bugs
srnagar
approved these changes
Jun 26, 2024
This was referenced Jun 27, 2024
|
@mssfang This is impactin the accuracy of the prompts, and we are seeing way worse results in the responses. The current release is not useable in production and we would request an early fix to this issue. |
|
I'm also experiencing the same issue, and I can reproduce it - I'll add a test for this in @langchain4j and I'll link it here, if you want to have this in your test suite too. |
Contributor
Author
|
Hi all beta.10 is out in maven now: https://repo1.maven.org/maven2/com/azure/azure-ai-openai/1.0.0-beta.10/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #40481
fixes: #40900
fixes: #40653
ChatRequestUserMessage's constructor can take String, BinaryData, List or ChatMessageContentItem[] type, we need to serialize and deserialize the
contentproperty correctly in the model.fixes: #40760 (typo)