MetricsClient Sovereign Cloud Support#40789
Closed
jairmyree wants to merge 2 commits into
Closed
Conversation
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
jairmyree
force-pushed
the
batch-metrics-sovereign-support
branch
from
9c5ee07 to
5107049
Compare
srnagar
reviewed
Jul 1, 2024
| /** | ||
| * The audience indicating the authorization scope of metrics clients. | ||
| */ | ||
| public class MetricsClientAudience extends ExpandableStringEnum<MetricsClientAudience> { |
Member
There was a problem hiding this comment.
This should be named MetricsAudience to be consistent with the names used in other libraries.
| /** | ||
| * Static value for Azure Public Cloud. | ||
| */ | ||
| public static final MetricsClientAudience AZURE_PUBLIC_CLOUD = fromString("https://metrics.monitor.azure.com//.default"); |
Member
There was a problem hiding this comment.
Why do we have // instead of / before .default?
Member
|
Completed in this PR - #41048 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces sovereign cloud support for
MetricsClientby introducingMetricsClientAudienceand autorest transforms to adjust logic to include audience specification.