Skip to content

Fixed benchmark default logging unit test for Spring boot 3 configuration#41000

Closed
kushagraThapar wants to merge 1 commit into
Azure:feature/spring-boot-3from
kushagraThapar:fix_cosmos_benchmark_logging_test
Closed

Fixed benchmark default logging unit test for Spring boot 3 configuration#41000
kushagraThapar wants to merge 1 commit into
Azure:feature/spring-boot-3from
kushagraThapar:fix_cosmos_benchmark_logging_test

Conversation

@kushagraThapar

@kushagraThapar kushagraThapar commented Jul 3, 2024

Copy link
Copy Markdown
Member
  • Because of Spring boot 3 configs, default logging level are different than what this unit test is configured for.
  • Fixed the unit test to check for default logging in slf4j-api -
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.13</version>

Failing test pipeline -> https://dev.azure.com/azure-sdk/public/_build/results?buildId=3931044&view=ms.vss-test-web.build-test-results-tab&runId=48613480&resultId=100000&paneView=debug

@github-actions github-actions Bot added the Cosmos label Jul 3, 2024

@trande4884 trande4884 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moarychan

Copy link
Copy Markdown
Member

Thanks! Cherry-picked to 87a98f0 in PR #40700

@kushagraThapar

Copy link
Copy Markdown
Member Author

Closing this PR as the commit has been cherry picked in another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants