Skip to content

dpg typespec, use DEFAULT_VERSION as new version to compare Jars #41023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weidongxu-microsoft merged 1 commit into from
Jul 8, 2024
Merged

dpg typespec, use DEFAULT_VERSION as new version to compare Jars #41023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/mgmt/automation/generate_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
repo_url: str = config["repoHttpsUrl"]
breaking: bool = False
changelog: str = ""
clean_sdk_folder_succeeded = False

succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
tsp_project, sdk_root, spec_root, head_sha, repo_url
Expand All @@ -54,6 +55,8 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
if require_sdk_integration:
update_service_files_for_new_lib(sdk_root, service, GROUP_ID, module)
update_root_pom(sdk_root, service)
if clean_sdk_folder_succeeded:
current_version = DEFAULT_VERSION

# compile
succeeded = compile_package(sdk_root, GROUP_ID, module)
Expand All @@ -74,7 +77,8 @@ def sdk_automation_typespec_project(tsp_project: str, config: dict) -> dict:
succeeded, require_sdk_integration, sdk_folder, service, module = generate_typespec_project(
tsp_project, sdk_root, spec_root, head_sha, repo_url
)
stable_version, current_version = set_or_default_version(sdk_root, GROUP_ID, module)
stable_version, = set_or_default_version(sdk_root, GROUP_ID, module)
current_version = DEFAULT_VERSION
if require_sdk_integration:
update_service_files_for_new_lib(sdk_root, service, GROUP_ID, module)
update_root_pom(sdk_root, service)
Expand Down