migrate azure messaging servicebus tests to use token auth. #41032
Merged
anuchandy merged 29 commits intoJul 9, 2024
Conversation
Collaborator
|
API change check API changes are not detected in this pull request. |
anuchandy
changed the title
anuchandy
force-pushed
the
test/anuchan/azure-messaging-servicebus-token-auth
branch
from
19f5e53 to
9f81080
Compare
conniey
reviewed
Jul 8, 2024
anuchandy
commented
Jul 8, 2024
anuchandy
force-pushed
the
test/anuchan/azure-messaging-servicebus-token-auth
branch
from
0dd3a66 to
3dd4402
Compare
conniey
reviewed
Jul 8, 2024
conniey
approved these changes
Jul 8, 2024
conniey
left a comment
conniey
left a comment
Member
There was a problem hiding this comment.
LGTM. Just a couple of follow-up comments. :D 🥂
conniey
reviewed
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated all tests to use federated identity, with following 2 exceptions –
ServiceBusNonFederatedIntegrationTest. While this test class looks eligible for auxiliary tenant, at the moment this class runs in CI using connection string.