Regions Contacted on Multi Region Diagnostics Fix#41045
Merged
Conversation
…aStatusList includes all replicas
…tvaron3/azure-sdk-for-java into tvaron3/diagnosticsImprovements
…to tvaron3/diagnosticsImprovements
…tvaron3/azure-sdk-for-java into tvaron3/diagnosticsImprovements
tvaron3
requested review from
FabianMeiswinkel,
Pilchie,
aayush3011,
jeet1995,
kirankumarkolli,
kushagraThapar,
milismsft,
simorenoh and
xinlian12
as code owners
tvaron3
commented
Jul 8, 2024
Collaborator
|
API change check API changes are not detected in this pull request. |
Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to tvaron3/diagnosticsImprovements
…tvaron3/azure-sdk-for-java into tvaron3/diagnosticsImprovements
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
regionsContactedfield in the diagnostics was displaying the wrong region for multi-region accounts that don't specify a preferred regions. We were returning the first location in a map of the location endpoints and the regions, so not necessarily the location related to the default endpoint. Now it should return the first region in the available write locations list. #40696