Skip to content

Revert "Fix spring autoconfigure test"#41046

Merged
conniey merged 1 commit into
mainfrom
revert-40980-spring-tests/container-fix
Jul 8, 2024
Merged

Revert "Fix spring autoconfigure test"#41046
conniey merged 1 commit into
mainfrom
revert-40980-spring-tests/container-fix

Conversation

@conniey

@conniey conniey commented Jul 8, 2024

Copy link
Copy Markdown
Member
  • Reverts Fix spring autoconfigure test #40980.
  • Environment variable TESTCONTAINERS_RYUK_DISABLED=true needs to be set on all runs that build from source and not just pipelines under sdk/spring

Example:
For a CI run of Event Hubs, it runs:

  • sdk/eventhubs/ci.yml, which calls:
    • eng/pipelines/templates/jobs/ci.yml
      • eng/pipelines/templates/jobs/ci.tests.yml
        • eng/pipelines/templates/steps/build-and-test.yml

In build-and-test.yml, it invokes the "Run tests for From Source run" task which does not have the TESTCONTAINERS_RYUK_DISABLED=true environment variable set, so the run fails. (This environment variable is only set in sdk/spring/ci.yml, so that CI build would succeed.).

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jul 8, 2024
@conniey conniey enabled auto-merge (squash) July 8, 2024 17:51
@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@conniey conniey self-assigned this Jul 8, 2024
@conniey conniey disabled auto-merge July 8, 2024 18:07
@conniey conniey merged commit 8aa025d into main Jul 8, 2024
@conniey conniey deleted the revert-40980-spring-tests/container-fix branch July 8, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure-spring All azure-spring related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants