Skip to content

Allow DefaultLogger to integrate better with newer versions of SLF4J#41064

Merged
alzimmermsft merged 1 commit into
Azure:mainfrom
alzimmermsft:AzCore_UseLoggerInsteadOfMarkerIgnoringLogger
Jul 9, 2024
Merged

Allow DefaultLogger to integrate better with newer versions of SLF4J#41064
alzimmermsft merged 1 commit into
Azure:mainfrom
alzimmermsft:AzCore_UseLoggerInsteadOfMarkerIgnoringLogger

Conversation

@alzimmermsft

Copy link
Copy Markdown
Member

Description

Have DefaultLogger in azure-core implementation implement Logger instead of MarkerIgnoringBase as it is deprecated in SLF4J 2.0.0+. This should allow for azure-core to integrate better with newer versions of SLF4J in case MarkerIgnoringBase is removed in later versions of SLF4J.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft alzimmermsft merged commit 6707fa2 into Azure:main Jul 9, 2024
@alzimmermsft alzimmermsft deleted the AzCore_UseLoggerInsteadOfMarkerIgnoringLogger branch July 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Azure.Core azure-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants