Skip to content

Support multiple Spring version integration tests#41170

Merged
moarychan merged 34 commits into
Azure:mainfrom
moarychan:moary/support-multiple-spring-versions-for-integration-tests
Jul 24, 2024
Merged

Support multiple Spring version integration tests#41170
moarychan merged 34 commits into
Azure:mainfrom
moarychan:moary/support-multiple-spring-versions-for-integration-tests

Conversation

@moarychan

@moarychan moarychan commented Jul 17, 2024

Copy link
Copy Markdown
Member

Description

Support multiple Spring version integration tests based on configuration file spring-cloud-azure-supported-spring.json.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions Bot added the azure-spring All azure-spring related issues label Jul 17, 2024
@moarychan

moarychan commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

/azp run java - spring - tests

@azure-pipelines

azure-pipelines Bot commented Jul 17, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@moarychan

moarychan commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

/azp run java - spring - tests

1 similar comment
@moarychan

moarychan commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

/azp run java - spring - tests

@azure-pipelines

azure-pipelines Bot commented Jul 17, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@moarychan moarychan marked this pull request as ready for review July 17, 2024 05:49
Netyyyy
Netyyyy reviewed Jul 17, 2024
View reviewed changes
Comment thread sdk/spring/pipeline/tests-supported-spring-versions-template.yml
Comment thread sdk/spring/pipeline/cosmos-integration-matrix.json Outdated
saragluna
saragluna reviewed Jul 17, 2024
View reviewed changes
Comment thread eng/pipelines/templates/stages/archetype-sdk-tests-isolated.yml
Comment thread eng/pipelines/templates/stages/archetype-sdk-tests-isolated.yml
Comment thread sdk/spring/pipeline/tests-supported-spring-versions-template.yml
@moarychan

moarychan commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

/azp run java - spring - tests

@azure-pipelines

azure-pipelines Bot commented Jul 17, 2024

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@moarychan

moarychan commented Jul 17, 2024

Copy link
Copy Markdown
Member Author

Hi @JimSuplizio, @benbp, @hallipr, @weshaggard, can any of you please review this PR? Thanks in advance!

@moarychan
Remove window and mac agent, because exception: com.azure.identity.Cr…
5b2d4b0 
…edentialUnavailableException: Encountered error when deserializing response from Azure Power Shell
@moarychan moarychan marked this pull request as draft July 22, 2024 01:16
@JimSuplizio JimSuplizio requested a review from alzimmermsft July 22, 2024 16:47
@JimSuplizio

JimSuplizio commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

@moarychan, I'm adding @alzimmermsft in case he has any feedback. I am going to say that it's kind of hard to review a PR considering the state of the java - spring - tests pipeline results are indicative of something catastrophic going on. I cannot approve these changes at this time.

@azure-sdk

azure-sdk commented Jul 23, 2024

Copy link
Copy Markdown
Collaborator

API change check

API changes are not detected in this pull request.

@moarychan moarychan marked this pull request as draft July 23, 2024 07:50
@moarychan moarychan marked this pull request as ready for review July 23, 2024 10:27
@moarychan

moarychan commented Jul 23, 2024

Copy link
Copy Markdown
Member Author

Now Spring tests run almost completely successfully, I will re-run the failed one, @JimSuplizio and @alzimmermsft, please help review. Many thanks!

JimSuplizio
JimSuplizio approved these changes Jul 23, 2024
View reviewed changes

@JimSuplizio JimSuplizio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with the eng changes.

@benbp

benbp commented Jul 23, 2024

Copy link
Copy Markdown
Member

I will review this today

@moarychan

moarychan commented Jul 24, 2024

Copy link
Copy Markdown
Member Author

/check-enforcer override

@moarychan moarychan merged commit 98825bb into Azure:main Jul 24, 2024
@saragluna saragluna mentioned this pull request Jul 29, 2024
Closed
@moarychan moarychan deleted the moary/support-multiple-spring-versions-for-integration-tests branch August 2, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saragluna saragluna saragluna approved these changes
@benbp benbp benbp approved these changes
@hallipr hallipr Awaiting requested review from hallipr
@weshaggard weshaggard Awaiting requested review from weshaggard
@rujche rujche Awaiting requested review from rujche rujche is a code owner
@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft
+2 more reviewers
@Netyyyy Netyyyy Netyyyy left review comments
@JimSuplizio JimSuplizio JimSuplizio approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

azure-spring All azure-spring related issues

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@moarychan @JimSuplizio @azure-sdk @benbp @saragluna @Netyyyy