Migrated Key Vault JCA library to use azure-json serialization/deserialization - #41508
Conversation
Alan Zimmer (alzimmermsft)
left a comment
There was a problem hiding this comment.
With the recommended changes to the JSON utilities class, you can delete out all the code copied from azure-core
|
Hey vcolin7, thanks for creating this PR. I am wondering whether we should revert the two changes you made for the AAD Login URL, before we merge in any PR? Seems like you are actively contributing to make the JCA library better, and we also have some features that want to be merged in, and out as regular release. So I think if those two changes won't be out as GA in the near future, maybe we should revert it, and merge it back to main when it's ready to GA. |
I think if you guys want to release a single feature that's already in |
b8b3774 to
2aa3fd6
Compare
|
Thanks vcolin7. But what I'm talking is we are having a PR #41303, we would like to merge into the main branch. But the main branch already has changes only suitable for beta releases. So my question is, should we use the main branch as a place for code ready for GA release, and move the code for beta releases to a feature branch? |
|
API change check API changes are not detected in this pull request. |
I think we should merge your PR to |
|
vcolin7 what's happening with this PR? Can we get this wrapped up? |
…ration # Conflicts: # sdk/keyvault/azure-security-keyvault-jca/pom.xml
…ration # Conflicts: # sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/KeyVaultClient.java # sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/model/SecretBundle.java # sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/AccessTokenUtil.java # sdk/keyvault/azure-security-keyvault-jca/src/main/java/com/azure/security/keyvault/jca/implementation/utils/JsonConverterUtil.java
|
/azp run java - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This library shades Jackson classes to avoid having many external dependencies, so I've gone ahead and done the same for azure-json. I did copy a number of classes over from azure-core, so maybe there's a better approach for that. Let me know what you think Alan Zimmer (@alzimmermsft).
For more information on this, see: #40614.