Skip to content

Rename test cert file suffix to avoid alert #41784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rujun Chen (rujche) wants to merge 2 commits into from
Closed

Rename test cert file suffix to avoid alert #41784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10b5324
Rename test files' suffix name from "pfx" to "pfx.test" to avoid alerts.
rujche Sep 11, 2024
bfff56a
Delete unused .gitignore.
rujche Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdk/keyvault/azure-security-keyvault-jca/.gitignore
View file
Open in desktop

This file was deleted.

10 changes: 5 additions & 5 deletions ...c/test/java/com/azure/security/keyvault/jca/implementation/utils/CertificateUtilTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ public void loadCertificateChainFromSecretBundleValueTest()
throws CertificateException, IOException, KeyStoreException, NoSuchAlgorithmException, NoSuchProviderException, PKCSException {
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/pem-exportable-key.pem", 1);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/pem-non-exportable-key.pem", 1);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/pkcs12-exportable-key.pfx", 1);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/pkcs12-non-exportable-key.pfx", 1);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/pkcs12-exportable-key.pfx.test", 1);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/pkcs12-non-exportable-key.pfx.test", 1);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/3-certificates-in-chain.pem", 3);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/3-certificates-in-chain.pfx", 3);
assertCertNumberInCertChain("src/test/resources/certificate-util/SecretBundle.value/3-certificates-in-chain.pfx.test", 3);
}

private void assertCertNumberInCertChain(String pemFile, int expectedNumber)
Expand All @@ -52,8 +52,8 @@ public void loadX509CertificateFromFileTest() throws IOException, CertificateExc
// Now just keep the test files and unit test codes, they may be used when implement the feature.
// certificateCanBeLoadFromFile("src/test/resources/certificate-util/downloaded-from-portal/pem-exportable-key.pem");
certificateCanBeLoadFromFile("src/test/resources/certificate-util/downloaded-from-portal/pem-non-exportable-key.pem");
// certificateCanBeLoadFromFile("src/test/resources/certificate-util/downloaded-from-portal/pkcs12-exportable-key.pfx");
// certificateCanBeLoadFromFile("src/test/resources/certificate-util/downloaded-from-portal/pkcs12-non-exportable-key.pfx");
// certificateCanBeLoadFromFile("src/test/resources/certificate-util/downloaded-from-portal/pkcs12-exportable-key.pfx.test");
// certificateCanBeLoadFromFile("src/test/resources/certificate-util/downloaded-from-portal/pkcs12-non-exportable-key.pfx.test");
certificateCanBeLoadFromFile("src/test/resources/custom/sideload.x509");
certificateCanBeLoadFromFile("src/test/resources/custom/sideload2.pem");
certificateCanBeLoadFromFile("src/test/resources/keyvault/sideload2.pem");
Expand Down
0 ...tBundle.value/3-certificates-in-chain.pfx → ...le.value/3-certificates-in-chain.pfx.test
View file
Open in desktop
File renamed without changes.
0 ...retBundle.value/pkcs12-exportable-key.pfx → ...ndle.value/pkcs12-exportable-key.pfx.test
View file
Open in desktop
File renamed without changes.
0 ...undle.value/pkcs12-non-exportable-key.pfx → ....value/pkcs12-non-exportable-key.pfx.test
View file
Open in desktop
File renamed without changes.
0 ...ded-from-portal/pkcs12-exportable-key.pfx → ...rom-portal/pkcs12-exportable-key.pfx.test
View file
Open in desktop
File renamed without changes.
0 ...from-portal/pkcs12-non-exportable-key.pfx → ...portal/pkcs12-non-exportable-key.pfx.test
View file
Open in desktop
File renamed without changes.