Skip to content

Added code to handle claims in authentication challenges #41814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcolin7 merged 19 commits into from
Oct 15, 2024
Merged

Added code to handle claims in authentication challenges #41814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b26df79
Added code to handle claims in authentication challenges.
vcolin7 Sep 11, 2024
c50077e
Updated KeyVaultCredentialPolicy to ensure CAE is enabled.
vcolin7 Sep 17, 2024
90cbd2e
Updated KeyVaultCredentialPolicy to handle a second 401 in case a tok…
vcolin7 Sep 19, 2024
103d113
Fixed an issue where `KeyVaultCredentialPolicy` would make an extra c…
vcolin7 Sep 26, 2024
b478be2
Added tests.
vcolin7 Sep 26, 2024
d5f96c1
Merge branch 'main' into feature/vicolina/keyvault/cae
vcolin7 Oct 7, 2024
e0b5dec
Reverted accidental commit.
vcolin7 Oct 7, 2024
5e09204
Ensured CAE is always enabled.
vcolin7 Oct 7, 2024
5d31764
Fixed a bug where challenge handling could fall into an infinite loo…
vcolin7 Oct 7, 2024
4aef99f
Updated tests
vcolin7 Oct 7, 2024
1b5173e
Updated all other KV packages.
vcolin7 Oct 7, 2024
a57cb96
Removed unused imports.
vcolin7 Oct 8, 2024
9d9d766
Optimized challenge processing.
vcolin7 Oct 8, 2024
b4072e5
Applied PR feedback to tests.
vcolin7 Oct 9, 2024
01f0ded
Applied more feedback and added additional tests.
vcolin7 Oct 14, 2024
f11c439
Added one more test.
vcolin7 Oct 14, 2024
f7038e4
Fixed compilation error.
vcolin7 Oct 14, 2024
bfa88a7
Fixed issue with BasicAuthenticationCredential.
vcolin7 Oct 14, 2024
76cb157
Fixed CheckStyle issues.
vcolin7 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
205 changes: 173 additions & 32 deletions ...a/com/azure/security/keyvault/administration/implementation/KeyVaultCredentialPolicy.java
View file
Open in desktop

Large diffs are not rendered by default.

581 changes: 504 additions & 77 deletions ...rc/test/java/com/azure/security/keyvault/administration/KeyVaultCredentialPolicyTest.java
View file
Open in desktop

Large diffs are not rendered by default.

201 changes: 171 additions & 30 deletions ...ava/com/azure/security/keyvault/certificates/implementation/KeyVaultCredentialPolicy.java
View file
Open in desktop

Large diffs are not rendered by default.

525 changes: 485 additions & 40 deletions .../src/test/java/com/azure/security/keyvault/certificates/KeyVaultCredentialPolicyTest.java
View file
Open in desktop

Large diffs are not rendered by default.

206 changes: 174 additions & 32 deletions ...c/main/java/com/azure/security/keyvault/keys/implementation/KeyVaultCredentialPolicy.java
View file
Open in desktop

Large diffs are not rendered by default.

524 changes: 485 additions & 39 deletions ...ult-keys/src/test/java/com/azure/security/keyvault/keys/KeyVaultCredentialPolicyTest.java
View file
Open in desktop

Large diffs are not rendered by default.

201 changes: 171 additions & 30 deletions ...ain/java/com/azure/security/keyvault/secrets/implementation/KeyVaultCredentialPolicy.java
View file
Open in desktop

Large diffs are not rendered by default.

523 changes: 485 additions & 38 deletions ...crets/src/test/java/com/azure/security/keyvault/secrets/KeyVaultCredentialPolicyTest.java
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion ...-keyvault-secrets/src/test/java/com/azure/security/keyvault/secrets/SecretClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ private void createClient(HttpClient httpClient, SecretServiceVersion serviceVer
private void createClient(HttpClient httpClient, SecretServiceVersion serviceVersion, String testTenantId) {
secretClient = getClientBuilder(buildSyncAssertingClient(interceptorManager.isPlaybackMode()
? interceptorManager.getPlaybackClient() : httpClient), testTenantId, getEndpoint(), serviceVersion)
.disableChallengeResourceVerification()
.buildClient();

if (!interceptorManager.isLiveMode()) {
Expand Down
5 changes: 0 additions & 5 deletions ...vault-secrets/src/test/java/com/azure/security/keyvault/secrets/SecretClientTestBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
import com.azure.core.http.HttpClient;
import com.azure.core.http.policy.ExponentialBackoffOptions;
import com.azure.core.http.policy.FixedDelayOptions;
import com.azure.core.http.policy.HttpLogDetailLevel;
import com.azure.core.http.policy.HttpLogOptions;
import com.azure.core.http.policy.RetryOptions;
import com.azure.core.test.TestProxyTestBase;
import com.azure.core.test.models.BodilessMatcher;
Expand Down Expand Up @@ -74,12 +72,10 @@ SecretClientBuilder getClientBuilder(HttpClient httpClient, String testTenantId,

if (interceptorManager.isLiveMode()) {
credential = new AzurePowerShellCredentialBuilder()
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.additionallyAllowedTenants("*")
.build();
} else if (interceptorManager.isRecordMode()) {
credential = new DefaultAzureCredentialBuilder()
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.additionallyAllowedTenants("*")
.build();
} else {
Expand All @@ -91,7 +87,6 @@ SecretClientBuilder getClientBuilder(HttpClient httpClient, String testTenantId,
}

SecretClientBuilder builder = new SecretClientBuilder()
.httpLogOptions(new HttpLogOptions().setLogLevel(HttpLogDetailLevel.BODY_AND_HEADERS))
.vaultUrl(endpoint)
.serviceVersion(serviceVersion)
.credential(credential)
Expand Down