Eg add response methods#41879
Merged
Merged
Conversation
Add missing withResponse methods for sending/receiving with a `RequestOptions`. Also ensure HTTP timeouts are set properly.
billwert
requested review from
lmolkova,
mssfang and
srnagar
as code owners
srnagar
reviewed
Sep 17, 2024
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
billwert
force-pushed
the
eg-add-response-methods
branch
from
b467dcf to
4ccd4b4
Compare
mssfang
pushed a commit
to mssfang/azure-sdk-for-java
that referenced
this pull request
Oct 21, 2024
* Add WithResponse methods Add missing withResponse methods for sending/receiving with a `RequestOptions`. Also ensure HTTP timeouts are set properly. * remove a couple extra methods * make `addTimeoutToContext` helper method package-private * remove extra comments * fix comment * just call the other method * Add a little buffer to the http timeout in the default case. * run tsp-client update to pick up formatting fixes * add a comment about how fractional seconds are handled.
samvaity
added a commit
to samvaity/azure-sdk-for-java
that referenced
this pull request
Apr 1, 2026
TypeSpec version gating restored for Azure Machine Learning, causing SDK generation changes and potential customization drift in Java SDK. Ref: Azure/azure-rest-api-specs#41879 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing withResponse methods for sending/receiving with a
RequestOptions.Also ensure HTTP timeouts are set properly.