Skip to content

Fix flaky AddressRepositoryIT tests due to non-deterministic ordering and ambiguous IDs #48071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kushagraThapar merged 4 commits into from
Feb 24, 2026
Merged

Fix flaky AddressRepositoryIT tests due to non-deterministic ordering and ambiguous IDs #48071

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21e1df7
Initial plan
Copilot Feb 23, 2026
bd7138a
Fix flaky AddressRepositoryIT tests - order-sensitive assertions and …
Copilot Feb 23, 2026
c8ef1c3
Merge branch 'main' into copilot/fix-address-repository-tests
rujche Feb 24, 2026
788e79b
Remove unused TEST_ADDRESS_TEMP variables from testFindAllByStreetNot…
Copilot Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ...rc/test/java/com/azure/spring/data/cosmos/repository/integration/AddressRepositoryIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,11 @@ public void setUp() {

@Test
public void testFindById() {
// test findById (ID id) cross partition
final Address result = repository.findById(TEST_ADDRESS1_PARTITION1.getPostalCode()).get();
// test findById (ID id) cross partition using a postal code that is unique across all test addresses
final Address result = repository.findById(TEST_ADDRESS1_PARTITION2.getPostalCode()).get();
assertThat(responseDiagnosticsTestUtils.getCosmosResponseStatistics()).isNotNull();
assertThat(responseDiagnosticsTestUtils.getCosmosDiagnostics().toString().contains("\"requestOperationType\":\"Query\"")).isTrue();
assertThat(result).isEqualTo(TEST_ADDRESS1_PARTITION1);
assertThat(result).isEqualTo(TEST_ADDRESS1_PARTITION2);
}

@Test
Expand Down Expand Up @@ -150,7 +150,7 @@ public void testFindByPostalCodeAndCityIn() {
final List<Address> result = TestUtils.toList(repository.findByPostalCodeInAndCity(postalCodes, city));

assertThat(result.size()).isEqualTo(2);
assertThat(result).isEqualTo(Lists.newArrayList(TEST_ADDRESS1_PARTITION1, TEST_ADDRESS2_PARTITION1));
assertThat(result).containsExactlyInAnyOrder(TEST_ADDRESS1_PARTITION1, TEST_ADDRESS2_PARTITION1);
}

@Test
Expand Down Expand Up @@ -367,12 +367,10 @@ public void testFindTopByOrderByStreetDesc() {

@Test
public void testFindAllByStreetNotNull() {
Address TEST_ADDRESS_TEMP = new Address(
TestConstants.POSTAL_CODE, null, TestConstants.CITY);
final List<Address> result = TestUtils.toList(repository.findAllByStreetNotNull());
assertThat(result.size()).isEqualTo(4);
assertThat(result).isEqualTo(Lists.newArrayList(TEST_ADDRESS1_PARTITION1, TEST_ADDRESS1_PARTITION2,
TEST_ADDRESS2_PARTITION1, TEST_ADDRESS4_PARTITION3));
assertThat(result).containsExactlyInAnyOrder(TEST_ADDRESS1_PARTITION1, TEST_ADDRESS1_PARTITION2,
TEST_ADDRESS2_PARTITION1, TEST_ADDRESS4_PARTITION3);

}

Expand All @@ -393,8 +391,6 @@ public void testFindTop3ByOrderByStreetDesc() {

@Test
public void testCountByStreetNotNull() {
Address TEST_ADDRESS_TEMP = new Address(
TestConstants.POSTAL_CODE, null, TestConstants.CITY);
final Long result = repository.countByStreetNotNull();
assertThat(result).isEqualTo(4);
}
Expand Down
Loading