Sync eng/common directory with azure-sdk-tools for PR 14461#48383
Merged
azure-sdk merged 3 commits intoMar 12, 2026
Conversation
Add DirectoryFilterPattern parameter to archetype-typespec-emitter.yml and New-RegenerateMatrix.ps1 to allow filtering the regeneration matrix by package directory name pattern. This enables azure-sdk-for-net's http-client-csharp-mgmt CI to only regenerate Azure.ResourceManager* SDKs instead of all TypeSpec SDKs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Address review feedback: wrap filtered results in @() to ensure reliable .Count, and fail fast with a clear error when no directories match the filter pattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Update DirectoryFilterPattern to split on commas and match any pattern, so callers can filter to multiple SDK prefixes (e.g., 'Azure.ResourceManager*,Azure.Provisioning*'). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
azure-sdk
added
EngSys
Contributor
There was a problem hiding this comment.
Pull request overview
This PR syncs eng/common changes from azure-sdk-tools PR 14461 by adding support for filtering which SDK directories are included when generating the TypeSpec regeneration matrix.
Changes:
- Add a
DirectoryFilterPatternparameter toNew-RegenerateMatrix.ps1to filter generation directories by name (supports comma-separated patterns). - Wire the new
DirectoryFilterPatternparameter througharchetype-typespec-emitter.ymlinto the matrix generation step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/common/scripts/New-RegenerateMatrix.ps1 | Adds directory filtering logic and a guard when the filtered set is empty. |
| eng/common/pipelines/templates/archetype-typespec-emitter.yml | Exposes DirectoryFilterPattern as a template parameter and passes it to the matrix generation script. |
weshaggard
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#14461 See eng/common workflow