Skip to content

Fix pipeline java - spring sometimes hang in JDK 21 + Ubuntu #48608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rujche wants to merge 8 commits into from
+9 −4
Closed

Fix pipeline java - spring sometimes hang in JDK 21 + Ubuntu #48608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e23b6c8
Try to fix pipeline java - spring not stable in Java 21
rujche Mar 27, 2026
6149dd6
Try to fix the pipeline block issue by adding 'Thread.sleep(2000)', j…
rujche Mar 27, 2026
47cadf1
Increase Thread.sleep to 5 seconds in unit tests for JDK 21 stability
rujche Mar 27, 2026
7b4dff5
Revert "Increase Thread.sleep to 5 seconds in unit tests for JDK 21 s…
rujche Mar 27, 2026
4dd3952
Revert "Try to fix the pipeline block issue by adding 'Thread.sleep(2…
rujche Mar 27, 2026
8e2a3a1
Add MatrixReplace
rujche Mar 27, 2026
6a38d7e
Update OS type by updating platform-matrixmjson
rujche Mar 27, 2026
7cbdcdb
Rename to SkipAzureTestReplace to testAllHttpClients
rujche Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion eng/pipelines/templates/stages/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ parameters:
- name: MatrixReplace
type: object
default: []
- name: testAllHttpClients

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testAllHttpClients is the only parameter in this template using lowerCamelCase; all other parameters use PascalCase (e.g., TestPipeline, MatrixReplace, TestParallelization). For consistency and discoverability, rename this to TestAllHttpClients (and update all call sites).

Suggested change
- name: testAllHttpClients
- name: TestAllHttpClients

Copilot uses AI. Check for mistakes.
type: boolean
default: false
- name: PreBuildSteps
type: object
default: []
Expand Down Expand Up @@ -121,7 +124,8 @@ extends:
- ${{ each replacement in parameters.MatrixReplace }}:
- ${{ replacement }}

- AZURE_TEST.*=.*/
- ${{ if ne(parameters.testAllHttpClients, true) }}:
- AZURE_TEST.*=.*/

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flag name suggests it only affects HTTP-client testing, but the replacement being toggled is AZURE_TEST.*=.*/, which will blank out any AZURE_TEST* matrix parameter (present or future), not just AZURE_TEST_HTTP_CLIENTS. Either narrow the replacement key regex to AZURE_TEST_HTTP_CLIENTS or rename the flag to reflect that it preserves all AZURE_TEST* variables.

Suggested change
- AZURE_TEST.*=.*/
- AZURE_TEST_HTTP_CLIENTS=.*/

Copilot uses AI. Check for mistakes.
- ${{ if eq(parameters.SDKType, 'data') }}:
- JavaTestVersion=(.*1)\.\d{2}(.*)/$1.11$2
PreBuildSteps: ${{ parameters.PreBuildSteps }}
Expand Down
6 changes: 3 additions & 3 deletions eng/pipelines/templates/stages/platform-matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
},
{
"Agent": {
"ubuntu-24.04": { "OSVmImage": "env:LINUXVMIMAGE", "Pool": "env:LINUXPOOL" }
"windows-2022": { "OSVmImage": "env:WINDOWSVMIMAGE", "Pool": "env:WINDOWSPOOL" }
},
"JavaTestVersion": "1.21",
"AZURE_TEST_HTTP_CLIENTS": "netty",
Comment on lines 93 to 97

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform-matrix.json is the default matrix config used by the shared archetype-sdk-client.yml template, so changing the Java 21 include entries from Ubuntu to Windows will shift Java 21 CI coverage to Windows for all service directories using the archetype (not just Spring). If the hang is Spring-specific, consider scoping this by using a Spring-only matrix override (e.g., a Spring-specific matrix file referenced from sdk/spring/ci.yml via MatrixConfigs/AdditionalMatrixConfigs) instead of modifying the global matrix.

Copilot uses AI. Check for mistakes.
Expand All @@ -106,7 +106,7 @@
},
{
"Agent": {
"ubuntu-24.04": { "OSVmImage": "env:LINUXVMIMAGE", "Pool": "env:LINUXPOOL" }
"windows-2022": { "OSVmImage": "env:WINDOWSVMIMAGE", "Pool": "env:WINDOWSPOOL" }
},
"JavaTestVersion": "1.21",
"AZURE_TEST_HTTP_CLIENTS": "JdkHttpClientProvider",
Expand All @@ -121,7 +121,7 @@
},
{
"Agent": {
"ubuntu-24.04": { "OSVmImage": "env:LINUXVMIMAGE", "Pool": "env:LINUXPOOL" }
"windows-2022": { "OSVmImage": "env:WINDOWSVMIMAGE", "Pool": "env:WINDOWSPOOL" }
},
"JavaTestVersion": "1.21",
"AZURE_TEST_HTTP_CLIENTS": "VertxHttpClientProvider",
Expand Down
1 change: 1 addition & 0 deletions sdk/spring/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,5 +611,6 @@ extends:
skipVerifyChangeLog: true
releaseInBatch: ${{ parameters.release_springcloudazurestartermonitor }}
TestParallelization: '1'
testAllHttpClients: true
MatrixFilters:

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new parameter follows the lowerCamelCase name introduced in the archetype template. If the archetype parameter is renamed to PascalCase for consistency (recommended), update this key accordingly so the value is actually applied.

Suggested change
MatrixFilters:
matrixFilters:

Copilot uses AI. Check for mistakes.
- JavaTestVersion=^(?!1.8|1.11).*
Loading