Skip to content

Sync eng/common directory with azure-sdk-tools for PR 14890 #48686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azure-sdk merged 5 commits into from
Apr 4, 2026
Merged

Sync eng/common directory with azure-sdk-tools for PR 14890 #48686

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e2ff95
Allow azure-sdk PRs to bypass CODEOWNERS section check and rename Cod…
Copilot Apr 2, 2026
1f2c45c
Use gh pr view to detect PR author instead of Build.RequestedFor
Copilot Apr 3, 2026
5e2395e
Reorder logic: check CODEOWNERS changed before gh API call, remove st…
Copilot Apr 3, 2026
8156337
Replace gh CLI with Invoke-RestMethod for PR author detection
Copilot Apr 3, 2026
88b0a33
Add retry parameters to Invoke-RestMethod for PR author lookup
Copilot Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions eng/common/pipelines/templates/steps/verify-codeowners-sections.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ parameters:

steps:
- ${{ if eq(variables['Build.Reason'], 'PullRequest') }}:
# 1. Check if CODEOWNERS changed; skip everything if it hasn't
# 1. Check if CODEOWNERS changed; if so, check whether the PR was opened by azure-sdk
- pwsh: |
$scriptPath = [System.IO.Path]::Combine("${{ parameters.SourceRootPath }}", "eng", "common", "scripts", "get-changedfiles.ps1")
try {
Expand All @@ -27,11 +27,26 @@ steps:

if (!$changedFiles) {
Write-Host "CODEOWNERS file has not changed."
Write-Host "##vso[task.setvariable variable=CodeownersChanged]false"
} else {
Write-Host "CODEOWNERS file has changed."
Write-Host "##vso[task.setvariable variable=CodeownersChanged]true"
Write-Host "##vso[task.setvariable variable=ShouldCheckCodeownersEdits]false"
exit 0
}

Write-Host "CODEOWNERS file has changed."

$prNumber = "$(System.PullRequest.PullRequestNumber)"
$repoName = "$(Build.Repository.Name)"
$prUrl = "https://api.github.com/repos/$repoName/pulls/$prNumber"
$prData = Invoke-RestMethod -Uri $prUrl -MaximumRetryCount 10 -RetryIntervalSec 6
$prAuthor = $prData.user.login
Write-Host "PR author: $prAuthor"
Comment thread
danieljurek marked this conversation as resolved.

if ($prAuthor -ieq "azure-sdk") {
Write-Host "PR opened by azure-sdk. Skipping CODEOWNERS section check."
Write-Host "##vso[task.setvariable variable=ShouldCheckCodeownersEdits]false"
exit 0
}

Write-Host "##vso[task.setvariable variable=ShouldCheckCodeownersEdits]true"
displayName: 'Check if CODEOWNERS changed'
workingDirectory: ${{ parameters.SourceRootPath }}
condition: and(succeeded(), ne(variables['Skip.VerifyCodeownersSections'], 'true'))
Expand All @@ -40,7 +55,7 @@ steps:
- template: /eng/common/pipelines/templates/steps/install-azsdk-cli.yml
parameters:
SourceRootPath: ${{ parameters.SourceRootPath }}
Condition: and(succeeded(), eq(variables['CodeownersChanged'], 'true'))
Condition: and(succeeded(), eq(variables['ShouldCheckCodeownersEdits'], 'true'))

# 3. Prepare before/after CODEOWNERS files
- pwsh: |
Expand All @@ -61,13 +76,13 @@ steps:

if ($LASTEXITCODE) {
Write-Host "Could not retrieve CODEOWNERS from HEAD~1. The file may be newly added. Skipping."
Write-Host "##vso[task.setvariable variable=CodeownersChanged]false"
Write-Host "##vso[task.setvariable variable=ShouldCheckCodeownersEdits]false"
exit 0
}
Write-Host "Extracted parent CODEOWNERS to $beforeFile"
displayName: 'Prepare CODEOWNERS before/after files'
workingDirectory: ${{ parameters.SourceRootPath }}
condition: and(succeeded(), eq(variables['CodeownersChanged'], 'true'))
condition: and(succeeded(), eq(variables['ShouldCheckCodeownersEdits'], 'true'))

# 4. Run the section comparison script
- task: Powershell@2
Expand All @@ -83,4 +98,4 @@ steps:
-TempDirectory "${{ parameters.TempDirectory }}"
pwsh: true
workingDirectory: ${{ parameters.SourceRootPath }}
condition: and(succeeded(), eq(variables['CodeownersChanged'], 'true'))
condition: and(succeeded(), eq(variables['ShouldCheckCodeownersEdits'], 'true'))