-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Fix Cosmos Spark change feed offset discovery timeout #50029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnabnandy7
wants to merge
1
commit into
Azure:main
Choose a base branch
from
arnabnandy7:fix/cosmos-change-feed-offset-timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+265
−26
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89 changes: 89 additions & 0 deletions
89
...cosmos/azure-cosmos-spark_3/src/main/scala/com/azure/cosmos/spark/OperationDeadline.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.azure.cosmos.spark | ||
|
|
||
| import reactor.core.{Exceptions => ReactorExceptions} | ||
| import reactor.core.publisher.Mono | ||
|
|
||
| import java.time.Duration | ||
| import java.util.concurrent.TimeoutException | ||
|
|
||
| private[spark] final class OperationDeadline private( | ||
| timeout: Duration, | ||
| operationName: String, | ||
| deadlineInNanos: Long) { | ||
|
|
||
| def remainingDuration: Duration = { | ||
| if (deadlineInNanos == Long.MaxValue) { | ||
| Duration.ofNanos(Long.MaxValue) | ||
| } else { | ||
| val remainingNanos = deadlineInNanos - System.nanoTime() | ||
| if (remainingNanos <= 0) { | ||
| throw timeoutException() | ||
| } | ||
|
|
||
| Duration.ofNanos(remainingNanos) | ||
| } | ||
| } | ||
|
|
||
| def block[T](mono: Mono[T]): T = { | ||
| try { | ||
| mono.timeout(remainingDuration).block() | ||
| } catch { | ||
| case error: RuntimeException if ReactorExceptions.unwrap(error).isInstanceOf[TimeoutException] => | ||
| throw timeoutException(error) | ||
| } | ||
| } | ||
|
|
||
| def sleep(durationInMillis: Int): Unit = { | ||
| val remaining = remainingDuration | ||
| val requested = Duration.ofMillis(durationInMillis.toLong) | ||
| val effective = if (requested.compareTo(remaining) < 0) requested else remaining | ||
|
|
||
| val millis = effective.toMillis | ||
| val additionalNanos = (effective.minusMillis(millis).toNanos).toInt | ||
| try { | ||
| Thread.sleep(millis, additionalNanos) | ||
| } catch { | ||
| case interrupted: InterruptedException => | ||
| Thread.currentThread().interrupt() | ||
| throw interrupted | ||
| } | ||
|
|
||
| if (requested.compareTo(remaining) >= 0) { | ||
| remainingDuration | ||
| } | ||
| } | ||
|
|
||
| private def timeoutException(cause: Throwable = null): TimeoutException = { | ||
| val exception = new TimeoutException( | ||
| s"$operationName did not complete within $timeout.") | ||
| if (cause != null) { | ||
| exception.initCause(cause) | ||
| } | ||
| exception | ||
| } | ||
| } | ||
|
|
||
| private[spark] object OperationDeadline { | ||
| def apply(timeout: Duration, operationName: String): OperationDeadline = { | ||
| require(timeout != null && !timeout.isZero && !timeout.isNegative, "timeout must be positive") | ||
|
|
||
| val timeoutNanos = try { | ||
| timeout.toNanos | ||
| } catch { | ||
| case _: ArithmeticException => Long.MaxValue | ||
| } | ||
| val deadline = if (timeoutNanos == Long.MaxValue) { | ||
| Long.MaxValue | ||
| } else { | ||
| try { | ||
| Math.addExact(System.nanoTime(), timeoutNanos) | ||
| } catch { | ||
| case _: ArithmeticException => Long.MaxValue | ||
| } | ||
| } | ||
| new OperationDeadline(timeout, operationName, deadline) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.