Removed Unsafe Buffer Duplication#6470
Merged
alzimmermsft merged 7 commits intoJan 9, 2020
Merged
Conversation
alzimmermsft
requested review from
gapra-msft,
jaschrep-msft,
rickle-msft and
sima-zhu
as code owners
November 21, 2019 19:35
sima-zhu
previously approved these changes
Nov 25, 2019
rickle-msft
previously approved these changes
Nov 25, 2019
alzimmermsft
dismissed stale reviews from rickle-msft and sima-zhu
via
November 27, 2019 17:20
92f7109
sima-zhu
approved these changes
Nov 27, 2019
Member
Author
|
@rickle-msft Should I close or merge this PR? |
Contributor
|
If we still think the original is unsafe, let's merge the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5912
Fixes an issue where testing Blob Cryptography could fail when interacting with a
DirectByteBuffer.BlobDecryptionPolicywas using an optimization where it duplicated aByteBuffer, duplication is a shallow reference copy. The copied buffer could be mutated, such as the case of buffered pools in Netty Reactor, which would result in the content having different state than expected. The optimization has been removed and the decrypted data is being stored in a newly allocated buffer every time.