Skip to content

azure-core-amqp: Consolidate getEndpointStates and naming changes.#6523

Merged
conniey merged 30 commits into
Azure:masterfrom
conniey:azure-core-fixes
Nov 25, 2019
Merged

azure-core-amqp: Consolidate getEndpointStates and naming changes.#6523
conniey merged 30 commits into
Azure:masterfrom
conniey:azure-core-fixes

Conversation

@conniey

@conniey conniey commented Nov 22, 2019

Copy link
Copy Markdown
Member

This is the last of the azure-core-amqp API review changes.

  • getEndpointStates() is the way we figure out the connection state of an AMQP link, session or connection. If the Flux closes or errors, that implies that the link itself is closed.
    • We had duplicated this work using getErrors() and getShutdownSignals().
  • Classes now use AutoCloseable

conniey added 21 commits November 22, 2019 15:40
@conniey
AmqpConnection implements AutoCloseable. Add getEndpointStates().
3851f19
@conniey
AmqpConnection/Link/Session. implements AutoCloseable. Add getEndpoin…
0c6c6a9 
…tStates().
@conniey
CBSNode implements AutoCloseable.
278ae19
@conniey
Delete EndpointStateNotifier. Add ShutdownSignals to Connection.
d299eb3
@conniey
Delete EndpointStateNotifierBase.
d71e863
@conniey
Update parameter name for MessageConstant.fromValue
6a4ccce
@conniey
Move AmqpExceptionHandler into implementation class.
c813b11
@conniey
Update documentation in AmqpReceiveLink.
91bca87
@conniey
Update CBS -> Cbs.
39633d1
@conniey
Fix CBSChannel.
d6e3a0b
@conniey
Add AmqpEndpointStateUtil.
9dfae9c
@conniey
Fix ReactorConnection.
b6ed6c0
@conniey
Fix errors in updated sender and receiver.
a3e203a
@conniey
Fix test errors.
c3cf06d
@conniey
Fix close build issue.
815c789
@conniey
Fix try/catch IOException.
15b2dde
@conniey
Fixing test breaks.
0bd64d1
@conniey
Fix assertions in test.
6de70bd
@conniey
Fixing test issue.
59ebdef
@conniey
Closing ReactorReceiver on errors or closures in link.
08837ea
@conniey
Fix test failures.
868a2db
@conniey conniey added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Nov 22, 2019
@conniey conniey self-assigned this Nov 22, 2019
srnagar
srnagar reviewed Nov 23, 2019
View reviewed changes
Comment thread ...e/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/CbsAuthorizationType.java Outdated

@srnagar srnagar Nov 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to expand CBS here just like we have done for other types?

@conniey conniey Nov 23, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CbsAuthorizationType is used in the ClaimsBasedSecurityNode class, I thought it would be overkill.

srnagar
srnagar approved these changes Nov 23, 2019
View reviewed changes
Comment thread sdk/core/azure-core-amqp/src/main/java/com/azure/core/amqp/implementation/ReactorSender.java Outdated

@srnagar srnagar Nov 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to endpointStates

@conniey
conniey merged commit 3cd81d5 into Azure:master Nov 25, 2019
@conniey
conniey deleted the azure-core-fixes branch November 25, 2019 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srnagar srnagar srnagar approved these changes
@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft
@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar
@jianghaolu jianghaolu Awaiting requested review from jianghaolu
@mssfang mssfang Awaiting requested review from mssfang

Assignees

@conniey conniey

Labels

Client This issue points to a problem in the data-plane of the library. Event Hubs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@conniey @srnagar