Add changes info to changelog and remove AZURE_LOG_LEVEL 2#6548
Merged
Conversation
mssfang
commented
Nov 26, 2019
mssfang
commented
Contributor
- Updated CHANGELOG
- Removed Debugging level, AZURE_LOG_LEVEL=2
mssfang
added
Client
mssfang
requested review from
alzimmermsft,
conniey,
danieljurek and
sima-zhu
as code owners
November 26, 2019 01:12
alzimmermsft
approved these changes
Nov 26, 2019
Co-Authored-By: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
conniey
reviewed
Nov 26, 2019
| @@ -7,4 +7,3 @@ jobs: | |||
| EnvVars: | |||
| AZURE_TEST_MODE: RECORD | |||
| AZURE_APPCONFIG_CONNECTION_STRING: $(java-azconfig-test-connection-string) | |||
Member
There was a problem hiding this comment.
why remove log level altogether? It I'd expect at least AZURE_LOG_LEVEL = 4 for warnings. It's hard to diagnose errors when the logs are blank without rerunning them yourself.
Contributor
Author
There was a problem hiding this comment.
OK. I will add AZURE_LOG_LEVEL = 3 in the next PR: #6572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.