Upgrade netty depedencies to latest version#6554
Merged
Merged
Conversation
srnagar
requested review from
alzimmermsft,
hemanttanwar and
jianghaolu
as code owners
November 26, 2019 11:30
alzimmermsft
approved these changes
Nov 26, 2019
joshfree
approved these changes
Nov 26, 2019
anuchandy
approved these changes
Nov 26, 2019
hemanttanwar
suggested changes
Nov 26, 2019
| <dependency> | ||
| <groupId>io.netty</groupId> | ||
| <artifactId>netty-transport-native-unix-common</artifactId> | ||
| <version>4.1.42.Final</version> |
Contributor
There was a problem hiding this comment.
Can we use this latest version 4.1.43.Final ?
Member
Author
There was a problem hiding this comment.
We are using 4.1.42.Final for all netty dependencies. So, I used the same version for these two as well. I will look into 4.1.43.Final for the next release.
Member
There was a problem hiding this comment.
Sharing my general opinion on dependencies: we want to be fast followers rather than jumping to the newest version immediately. If we can understand where the community is (and I have tooling that can help here), we can move in step with the pack to try to minimise dependency conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrading some of the internal netty dependencies used by reactor-netty to the latest version.