Hide secret info from log info (#6555)#6623
Merged
alzimmermsft merged 3 commits intoDec 5, 2019
Merged
Conversation
alzimmermsft
commented
Dec 4, 2019
alzimmermsft
commented
Member
- Hide secret info from log info
* Hide secret info from log info
alzimmermsft
requested review from
hemanttanwar,
jianghaolu and
srnagar
as code owners
December 4, 2019 00:32
sima-zhu
approved these changes
Dec 4, 2019
alzimmermsft
requested review from
JimSuplizio,
JonathanGiles,
conniey,
danieljurek,
g2vinay,
gapra-msft,
jaschrep-msft,
joshfree,
mitchdenny,
mssfang,
samvaity and
weshaggard
as code owners
December 4, 2019 00:58
srnagar
approved these changes
Dec 4, 2019
alzimmermsft
removed request for
JonathanGiles,
danieljurek,
g2vinay,
hemanttanwar,
jianghaolu,
joshfree,
mitchdenny and
weshaggard
December 4, 2019 01:30
alzimmermsft
removed request for
JimSuplizio,
conniey,
gapra-msft,
jaschrep-msft,
mssfang,
rickle-msft and
samvaity
December 4, 2019 01:30
JimSuplizio
reviewed
Dec 4, 2019
JimSuplizio
approved these changes
Dec 4, 2019
JimSuplizio
left a comment
JimSuplizio
left a comment
Contributor
There was a problem hiding this comment.
I'm fine with the version changes but I did have one question about whether the dependency version should have been ticked up to 1.1.1 or left at 1.1.0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.