Skip to content

Update Event Hubs Azure template to fix tests#7844

Merged
conniey merged 21 commits into
Azure:masterfrom
conniey:fix-tests
Feb 5, 2020
Merged

Update Event Hubs Azure template to fix tests#7844
conniey merged 21 commits into
Azure:masterfrom
conniey:fix-tests

Conversation

@conniey

@conniey conniey commented Jan 30, 2020 •
edited
Loading

Copy link
Copy Markdown
Member
  • Fixes the two failing live tests because an authorization rule allowing access to the Event Hub was not added.
  • Removes creation and output of unnecessary storage resources (files, queues, data lake).
  • Removes incorrect CORS rules in Event Hubs.
  • Fixes bug in output parameter names.
  • Alphabetises variable names and corrects namespace name.
  • Fixes indentation.

Fixes #6664

@conniey
conniey requested a review from mssfang as a code owner January 30, 2020 15:50
@conniey conniey self-assigned this Jan 30, 2020
@conniey

conniey commented Jan 30, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Jan 30, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@conniey

conniey commented Feb 3, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Feb 3, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@hemanttanwar

hemanttanwar commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

@conniey There were few error in live test related to PartitionPump, please look into them.

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=250318&view=logs&jobId=27eb5d14-7214-5d9c-6bac-653552bd18b3&j=27eb5d14-7214-5d9c-6bac-653552bd18b3&t=8c9b85f5-3240-5af8-b929-e53e815dfe57

@conniey

conniey commented Feb 4, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Feb 4, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@conniey

conniey commented Feb 4, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Feb 4, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@conniey
conniey requested a review from danieljurek as a code owner February 4, 2020 22:45
@conniey

conniey commented Feb 4, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Feb 4, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@conniey

conniey commented Feb 5, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Feb 5, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@conniey

conniey commented Feb 5, 2020

Copy link
Copy Markdown
Member Author

/azp run java - eventhubs - tests

@azure-pipelines

azure-pipelines Bot commented Feb 5, 2020

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@conniey
conniey merged commit 7e52582 into Azure:master Feb 5, 2020
@conniey
conniey deleted the fix-tests branch February 5, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srnagar srnagar Awaiting requested review from srnagar
@mssfang mssfang Awaiting requested review from mssfang
@danieljurek danieljurek Awaiting requested review from danieljurek
1 more reviewer
@hemanttanwar hemanttanwar hemanttanwar approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@conniey conniey

Labels

Event Hubs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate why EventHubs live tests are consistently failing

2 participants

@conniey @hemanttanwar