Skip to content

Add configuration for refresh token before expiry#8715

Merged
jianghaolu merged 6 commits into
Azure:masterfrom
jianghaolu:refreshbeforeexpiry
Mar 6, 2020
Merged

Add configuration for refresh token before expiry#8715
jianghaolu merged 6 commits into
Azure:masterfrom
jianghaolu:refreshbeforeexpiry

Conversation

@jianghaolu

@jianghaolu jianghaolu commented Mar 5, 2020

Copy link
Copy Markdown
Contributor

Add tests later but just opening a PR for design discussion.

Fixes #6182

Sample usage:

ManagedIdentityCredential credential = new ManagedIdentityCredentialBuilder()
    .clientId("user managed identity client id")
    .tokenRefreshOffset(Duration.ofMinutes(10))
    .build();

@jianghaolu jianghaolu requested a review from srnagar March 5, 2020 01:18

@JonathanGiles JonathanGiles left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. I would like to workshop on the name, improve the docs, and run the issue past @anuchandy as well.

@jianghaolu jianghaolu marked this pull request as ready for review March 5, 2020 22:36
@jianghaolu jianghaolu merged commit d408073 into Azure:master Mar 6, 2020
@jianghaolu jianghaolu deleted the refreshbeforeexpiry branch October 5, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QUERY] AccessToken refresh - should cache expiry be made configurable?

5 participants