Add configuration for refresh token before expiry#8715
Merged
Conversation
jianghaolu
commented
Mar 5, 2020
jianghaolu
commented
Mar 5, 2020
jianghaolu
commented
Mar 5, 2020
JonathanGiles
left a comment
Member
There was a problem hiding this comment.
Generally looks good. I would like to workshop on the name, improve the docs, and run the issue past @anuchandy as well.
anuchandy
reviewed
Mar 5, 2020
srnagar
approved these changes
Mar 5, 2020
anuchandy
approved these changes
Mar 6, 2020
g2vinay
approved these changes
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests later but just opening a PR for design discussion.
Fixes #6182
Sample usage: