Migrate Azure.AI.ContentSafety to new Emitter #54611
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radhgupta
requested review from
JonathanCrd,
JoshLove-msft and
jorgerangel-msft
radhgupta
changed the title
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Member
jorgerangel-msft
left a comment
jorgerangel-msft
left a comment
There was a problem hiding this comment.
There are some code checks that are failing https://dev.azure.com/azure-sdk/public/_build/results?buildId=5685364&view=logs&j=c3e74943-23a9-5e82-9b42-8286fce989d4&t=e049197e-d864-58b1-c0e9-38458fd26878. At a glance, we may need to re-export the API files.
sdk/contentsafety/Azure.AI.ContentSafety/src/Customizations/BlocklistClient.cs
Outdated
Show resolved
Hide resolved
sdk/contentsafety/Azure.AI.ContentSafety/src/Customizations/ContentSafetyClient.cs
Outdated
Show resolved
Hide resolved
...tentsafety/Azure.AI.ContentSafety/src/Customizations/ContentSafetyClientBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
| @@ -1,457 +0,0 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
Member
There was a problem hiding this comment.
Lets move these docs out of the generated folder vs deleted them since the new generator doesn't support doc generation yet.
JonathanCrd
reviewed
Dec 19, 2025
Member
JonathanCrd
left a comment
JonathanCrd
left a comment
There was a problem hiding this comment.
Left a couple of comments.
There are other task that are still needed for this PR:
- There will be changes in the API, you have to regenerate them by running:
eng\scripts\Export-API.ps1 contentsafety
- Test are failing due to "missing" recordings, but by looking at the CI logs this is actually a bug where the request URL is malformed with a duplicated path component, here.
sdk/contentsafety/Azure.AI.ContentSafety/src/Customizations/BlocklistClient.cs
Outdated
Show resolved
Hide resolved
...tentsafety/Azure.AI.ContentSafety/src/Customizations/ContentSafetyClientBuilderExtensions.cs
Show resolved
Hide resolved
radhgupta
force-pushed
the
migrateContentSafety
branch
from
56469b9 to
d84a42a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.
Resolved: #54491