Hardcoding prefixname in create_resource causes ResoruceNotFound when deleting resource group

[00Kai0]

Hi Sean Kane (@seankane-msft) , can you remove this prefix in create_resource.

It causes a problem that our testcase couldn't remove test resource group correctly.
I think we don't need hardcode this prefix of group name, it generated by testcase and test script name.
If it's needed, we could rename our test script name for tracking purposes.

cc: Yu Chen (@jsntcy) Yuchao Yan (@msyyc)

Log:

__init__.py                235 INFO     <Request (DELETE) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_cli_mgmt_automation_test_automation53db109a?api-version=2020-10-01> not in cassette, sending to real server
cassette.py                232 INFO     Appending request <Request (DELETE) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/test_cli_mgmt_automation_test_automation53db109a?api-version=2020-10-01> and response {'status': {'code': 404, 'message': 'Not Found'}, 'headers': {'x-ms-failure-cause': ['gateway'], 'Content-Type': ['application/json; charset=utf-8'], 'x-ms-ratelimit-remaining-subscription-deletes': ['14999'], 'x-ms-correlation-request-id': ['84b14f55-1442-422a-842d-d9c3873d99dd'], 'Cache-Control': ['no-cache'], 'Pragma': ['no-cache'], 'Date': ['Sun, 25 Apr 2021 05:45:51 GMT'], 'Expires': ['-1'], 'x-ms-request-id': ['84b14f55-1442-422a-842d-d9c3873d99dd'], 'Strict-Transport-Security': ['max-age=31536000; includeSubDomains'], 'Content-Length': ['140'], 'X-Content-Type-Options': ['nosniff'], 'x-ms-routing-request-id': ['SOUTHEASTASIA:20210425T054551Z:84b14f55-1442-422a-842d-d9c3873d99dd']}, 'body': {'string': b'{"error":{"code":"ResourceGroupNotFound","message":"Resource group \'test_cli_mgmt_automation_test_automation53db109a\' could not be found."}}'}}
_universal.py              452 INFO     Response status: 404
_universal.py              453 INFO     Response headers:
_universal.py              456 INFO         'x-ms-failure-cause': 'REDACTED'
_universal.py              456 INFO         'Content-Type': 'application/json; charset=utf-8'
_universal.py              456 INFO         'x-ms-ratelimit-remaining-subscription-deletes': 'REDACTED'
_universal.py              456 INFO         'x-ms-correlation-request-id': 'REDACTED'
_universal.py              456 INFO         'Cache-Control': 'no-cache'
_universal.py              456 INFO         'Pragma': 'no-cache'
_universal.py              456 INFO         'Date': 'Sun, 25 Apr 2021 05:45:51 GMT'
_universal.py              456 INFO         'Expires': '-1'
_universal.py              456 INFO         'x-ms-request-id': '84b14f55-1442-422a-842d-d9c3873d99dd'
_universal.py              456 INFO         'Strict-Transport-Security': 'REDACTED'
_universal.py              456 INFO         'Content-Length': '140'
_universal.py              456 INFO         'X-Content-Type-Options': 'REDACTED'
_universal.py              456 INFO         'x-ms-routing-request-id': 'REDACTED'
resource_testcase.py       114 INFO     Failed to delete resource group with name test_cli_mgmt_automation_test_automation53db109a
resource_testcase.py       115 INFO     (ResourceGroupNotFound) Resource group 'test_cli_mgmt_automation_test_automation53db109a' could not be found.

[seankane-msft]

Wes Haggard (@weshaggard) we added this for tracking purposes with the clean-up script. What are your thoughts on removing this? If we don't remove this we need to change the logic of the delete_resource method to also prefix with rgpy-.

[weshaggard]

Kerwin(Kaihui) Sun (@00Kai0) is there some reason that the tests cannot be updated to either handle the new naming pattern? If they are hardcoding the resource group name they should be updated to be more dynamic and be able to handle any name from this helper script. So unless there is a strong reason I'd prefer to update the tests instead of the common infrastructure.

[seankane-msft]

Kerwin(Kaihui) Sun (@00Kai0) and Wes Haggard (@weshaggard) I think I have a PR in #18304 that fixes this issue, please review and let me know your thoughts