azure.keyvault.secrets begin_delete_secret has invalid type signature

[bmc-msft]

• Package Name: azure.keyvault.secrets
• Package Version: 4.3.0
• Operating System: Ubuntu-20.04
• Python Version: 3.8.5

Describe the bug

The type signature for begin_delete_secret states this function returns a DeletedSecret instead of a LROPoller[DeletedSecret] or KeyVaultOperationPoller[DeletedSecret].

The implementation of the type signature states:

azure-sdk-for-python/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py

Lines 296 to 297 in c8291ac

	def begin_delete_secret(self, name, **kwargs):
	# type: (str, **Any) -> DeletedSecret

This disagrees with both the documentation:

azure-sdk-for-python/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py

Line 309 in c8291ac

:rtype: ~azure.core.polling.LROPoller[~azure.keyvault.secrets.DeletedSecret]

And the implementation:

azure-sdk-for-python/sdk/keyvault/azure-keyvault-secrets/azure/keyvault/secrets/_client.py

Line 338 in c8291ac

return KeyVaultOperationPoller(polling_method)

To Reproduce
Steps to reproduce the behavior:

The following is invalid according to mypy:

client = SecretClient(valut_url=vault_url, credential=DefaultAzureCredential())
client.begin_delete_secret(secret).wait()

[xiangyan99]

Thanks for the feedback, we’ll investigate asap.

[laiapat]

Hi @bmc-msft, thank you for opening this issue! You're completely right that the type signature is incorrect here. It's an old issue that we should have caught -- I'll include this in our work for July's beta releases.