Skip to content

[AMQP Python] pass batch=self._link_credit to connection in ReceiveClient._client_run #24888

Description

@swathipil

We pass batch=self._prefetch in to ReceiveClient.do_work when receiving in the SDK.

self._handler.do_work(batch=self._prefetch) # type: ignore

However, we know that this prefetch has already been passed in during ReceiveClient instantiation and set to _link_credit in that client.

So, passing in the prefetch is unnecessary in the SDK when calling do_work. We can just pass in batch=self._link_credit to the self._connection.listen here:

self._connection.listen(wait=self._socket_timeout, **kwargs)
. This will help us further unify the pyamqp/uamqp logic in the SDKs.

Metadata

Metadata

Labels

AMQP PythonClientThis issue points to a problem in the data-plane of the library.Event HubsMessagingMessaging crew

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions