Skip to content

KV should not import anything requests specific  #25533

Description

This is wrong:

transport = kwargs.pop("transport", RequestsTransport(**kwargs))

This overrides the default transport that azure-core is providing, KV should trust azure-core to provide a transport in absence of the kwarg.

If requests is not installed on the machine, the import will be lazy loaded so it won't fail at import time, but at runtime the RequestsTransport will be interpreted before the kwargs.pop is read, and will crash KV. See this repro:

image

Talk to me if it's unclear :)

Metadata

Metadata

Labels

ClientThis issue points to a problem in the data-plane of the library.KeyVaultbugThis issue requires a change to an existing behavior in the product in order to be resolved.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions