Skip to content

Prevent circular dependencies with singleton classes and logs #44671

Description

@jeremydvoss

Discussion
Example issue

The core of this issue is that logs that are produced during setup hit the Breeze or Performance Counter log record processor that may still be in the process of starting up. This can cause circular dependencies and permanent Singleton locks. While this issue has been prevented by reordering setup, we should explore some more root-level solutions. For instance, I think we should change Singleton accessing to return None if the lock is stuck. This would prevent a crash at the cost of a single log being uncounted for the given processor. Alternatively, we could change the Live Metric and Performance Counter processors to not rely on the manager singletons directly, but rather use another module that the singleton relies on, too. This way, the processors can be fully independent of the managers.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions