Skip to content

Verify change log issue #10439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praveenkuttappan merged 4 commits into from
Mar 23, 2020
Merged

Verify change log issue #10439

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4f51fc
Skip service fabric from verify change log
praveenkuttappan Mar 23, 2020
3650ac7
Updated comments
praveenkuttappan Mar 23, 2020
d758477
Added additional comment
praveenkuttappan Mar 23, 2020
0be4ae1
Added logging
praveenkuttappan Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions scripts/devops_tasks/verify_change_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@

from common_tasks import process_glob_string, parse_setup, run_check_call

excluded_packages = ["azure"]

logging.getLogger().setLevel(logging.INFO)

root_dir = os.path.abspath(os.path.join(os.path.abspath(__file__), "..", "..", ".."))
psscript = os.path.join(root_dir, "scripts", "devops_tasks", "find_change_log.ps1")

# Service fabric change log has non standard versioning for e.g 7.0.0.0
# Verify change log should skip this package since this script looks for standard version format of x.y.z
NON_STANDARD_CHANGE_LOG_PACKAGES = ["azure-servicefabric",]

def find_change_log(targeted_package, version):
# Execute powershell script to find a matching version in change log
Expand Down Expand Up @@ -57,8 +59,9 @@ def verify_packages(targeted_packages):
# Parse setup.py using common helper method to get version and package name
pkg_name, version, _, _ = parse_setup(package)

# Skip management packages
if "-mgmt" in pkg_name or pkg_name in excluded_packages:
# Skip management packages and any explicitly excluded packages
if "-mgmt" in pkg_name or pkg_name in NON_STANDARD_CHANGE_LOG_PACKAGES:
Comment thread
scbedd marked this conversation as resolved.
logging.info("Skipping {} due to known exclusion in change log verification".format(pkg_name))
continue

if not find_change_log(package, version):
Expand Down