Add attributes in method AbstractSpan.link(cls, traceparent) - #10906
Merged
Conversation
rakshith91
marked this pull request as ready for review
April 18, 2020 06:27
rakshith91
requested review from
bryevdv,
johanste,
lmazuel and
xiangyan99
as code owners
April 18, 2020 06:27
YijunXieMS
reviewed
Apr 20, 2020
YijunXieMS
left a comment
YijunXieMS
left a comment
Contributor
There was a problem hiding this comment.
There is a new test or open telemetry implementation. Will there be the same one for open census?
lmazuel
requested changes
Apr 20, 2020
lmazuel
left a comment
lmazuel
left a comment
Member
There was a problem hiding this comment.
Need:
- Update in FakeSpan in azure-core/test/tracing_common.py (mimic API, but raise NotImplementedError)
- Update opencensus tests
lmazuel
approved these changes
Apr 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #10765